Merged
Conversation
This was referenced Feb 13, 2026
dba70d4 to
e0d65fd
Compare
aaronl-openai
approved these changes
Feb 13, 2026
git-stack-id: fjord/js_repl_seq---4hqgloumyo34bp git-stack-title: Add js_repl kernel crash diagnostics
e0d65fd to
6159258
Compare
owenlin0
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves
js_replcrash diagnostics so kernel failures are debuggable without weakening timeout/reset guarantees.What Changed
pid, exit status, stderr tail) for failure paths.js_repl diagnostics: {...}Why
Before this, failures like broken pipe / unexpected kernel exit often surfaced as generic errors with little context. This change preserves existing behavior but adds actionable diagnostics while keeping output bounded.
Scope
/Users/fjord/code/codex-jsrepl-seq/codex-rs/core/src/tools/js_repl/mod.rsValidation
cargo clippy -p codex-core --all-targets -- -D warningscodex-corejs_repl unit tests (including new diagnostics/timeout coverage)git stack
1Add js_repl kernel crash diagnostics #116662Add feature-gated js_repl polling flow #106733Add optional js_repl isolation and vendored Node runtime #10670