Skip to content

feat(core): wire structured network approvals through orchestration and retry flow#11673

Merged
viyatb-oai merged 6 commits intocodex/viyatb/pr-b-network-core-plumbingfrom
codex/viyatb/pr-c-network-core-orchestration
Feb 13, 2026
Merged

feat(core): wire structured network approvals through orchestration and retry flow#11673
viyatb-oai merged 6 commits intocodex/viyatb/pr-b-network-core-plumbingfrom
codex/viyatb/pr-c-network-core-orchestration

Conversation

@viyatb-oai
Copy link
Collaborator

Description

Summary

Integrates structured network approvals into the core orchestration path.

What changed

  • Wired structured network approval handling into tool orchestration/retry paths.
  • Integrated approval outcomes into command execution lifecycle.
  • Added orchestration-level handling for allow-once/session approval behavior.
  • Connected core session/delegate surfaces required for end-to-end approval flow.
  • Updated related core test coverage for orchestration behavior.

Why

With plumbing in place from parent, this PR makes network approvals operational in core command execution flow.

Notes

  • Gated behavior remains aligned with managed network requirements and sandbox policy.

Copy link
Collaborator

@dylan-hurd-oai dylan-hurd-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to shield this logic more strictly from the core loop when disabled

session.handle_inline_network_policy_request(request).await
}
}
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. It looks like we're constructing this regardless of whether network config is set up? Why not put this inside the let block?
  2. Can we abstract this from the core function here?

viyatb-oai and others added 4 commits February 12, 2026 22:20
Reconcile restacked PR-C with the updated PR-B base by restoring the network policy helper module and updating callsites for network attempt/context fields.

Also fills new ExecParams initializers in app-server and exec-server to keep workspace builds green.

Co-Authored-By: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Restore shell/unified-exec/process-manager/mcp-server implementations to the pre-restack PR-C behavior to avoid dropping network-approval runtime logic.

Co-Authored-By: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
@viyatb-oai viyatb-oai force-pushed the codex/viyatb/pr-c-network-core-orchestration branch from cdc3ccf to b010edf Compare February 13, 2026 06:29
@viyatb-oai viyatb-oai marked this pull request as ready for review February 13, 2026 07:21
@viyatb-oai viyatb-oai merged commit 881f50f into codex/viyatb/pr-b-network-core-plumbing Feb 13, 2026
10 of 31 checks passed
@viyatb-oai viyatb-oai deleted the codex/viyatb/pr-c-network-core-orchestration branch February 13, 2026 07:21
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants