fix: use locally bundled models when remote_models disabled#11691
Closed
sayan-oai wants to merge 1 commit intodev/sayan/warn-on-fallback-metadatafrom
Closed
fix: use locally bundled models when remote_models disabled#11691sayan-oai wants to merge 1 commit intodev/sayan/warn-on-fallback-metadatafrom
sayan-oai wants to merge 1 commit intodev/sayan/warn-on-fallback-metadatafrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We see issues like #11527 when a user has
remote_modelsdisabled, as we always use the default fallbackModelInfo. This causes issues with model performance. #11690 helps by warning the user when they are using the default fallback, but we shouldn't use the fallback if we have matchingModelInfoin the locally bundledmodels.json.I added
ModelsManager::bundled_modelsas a new field, but we could also readModelsManager::remote_modelsif we are ok with using cached model info whenremote_modelsis disabled.Tests
Updated existing test to confirm we don't use the default model info when
remote_modelsis disabled with a slug that's in the locally bundledmodels.json.