[app-server] add fuzzyFileSearch/sessionCompleted#11773
[app-server] add fuzzyFileSearch/sessionCompleted#11773nornagon-openai merged 2 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11017c879c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub struct FuzzyFileSearchSessionCompletedNotification { | ||
| pub session_id: String, |
There was a problem hiding this comment.
fuzzyFileSearch/sessionCompleted currently exposes only sessionId, but completions are emitted per-session over time (initial crawl plus subsequent query runs in app-server/src/fuzzy_file_search.rs), so clients cannot disambiguate which query actually finished when notifications are buffered or arrive after a newer update call. In that common rapid-typing path, a stale completion can incorrectly stop the spinner for the current query; sessionUpdated already includes query, and the README text for this event also documents a query field.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
will address this in a followup, for now i don't feel it's too important.
2 participants
this is to allow the client to know when to stop showing a spinner.