Skip to content

tests(js_repl): stabilize CI runtime test execution#12407

Merged
fjord-oai merged 1 commit intomainfrom
fjord/js_repl_seq---4htl2cund94dlu
Feb 25, 2026
Merged

tests(js_repl): stabilize CI runtime test execution#12407
fjord-oai merged 1 commit intomainfrom
fjord/js_repl_seq---4htl2cund94dlu

Conversation

@fjord-oai
Copy link
Contributor

@fjord-oai fjord-oai commented Feb 21, 2026

Summary

Stabilize js_repl runtime test setup in CI and move tool-facing js_repl behavior coverage into integration tests.

This is a test/CI change only. No production js_repl behavior change is intended.

Why

  • Bazel test sandboxes (especially on macOS) could resolve a different node than the one installed by actions/setup-node, which caused js_repl runtime/version failures.
  • js_repl runtime tests depend on platform-specific sandbox/test-harness behavior, so they need explicit gating in a base-stability commit.
  • Several tests in the js_repl unit test module were actually black-box/tool-level behavior tests and fit better in the integration suite.

Changes

  • Add actions/setup-node to the Bazel and Rust Tests workflows, using the exact version pinned in the repo’s Node version file.
  • In Bazel (non-Windows), pass CODEX_JS_REPL_NODE_PATH=$(which node) into test env so js_repl uses the actions/setup-node runtime inside Bazel tests.
  • Add a new integration test suite for js_repl tool behavior and register it in the core integration test suite module.
  • Move black-box js_repl behavior tests into the integration suite (persistence/TLA, builtin tool invocation, recursive self-call rejection, process isolation, blocked builtin imports).
  • Keep white-box manager/kernel tests in the js_repl unit test module.
  • Gate js_repl runtime tests to run only on macOS and only when a usable Node runtime is available (skip on other platforms / missing Node in this commit).

Impact

  • Reduces js_repl CI failures caused by Node resolution drift in Bazel.
  • Improves test organization by separating tool-facing behavior tests from white-box manager/kernel tests.
  • Keeps the base commit stable while expanding js_repl runtime coverage.

git stack

@etraut-openai etraut-openai added the oai PRs contributed by OpenAI employees label Feb 21, 2026
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htl2cund94dlu branch 2 times, most recently from c64d1c1 to f26ef7a Compare February 21, 2026 04:29
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htl2cund94dlu branch 4 times, most recently from cec24cc to 6757420 Compare February 21, 2026 17:01
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htl2cund94dlu branch 4 times, most recently from 81baef0 to 7d20fa3 Compare February 22, 2026 22:21
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htl2cund94dlu branch 3 times, most recently from 9d00b9f to 21e5fa9 Compare February 25, 2026 03:10
git-stack-id: fjord/js_repl_seq---4htl2cund94dlu
git-stack-title: tests(js_repl): stabilize CI runtime test execution
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htl2cund94dlu branch from 21e5fa9 to 2362ec2 Compare February 25, 2026 03:59
@fjord-oai fjord-oai merged commit 8f3f2c3 into main Feb 25, 2026
100 of 110 checks passed
@fjord-oai fjord-oai deleted the fjord/js_repl_seq---4htl2cund94dlu branch February 25, 2026 05:04
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

oai PRs contributed by OpenAI employees

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants