fix(linux-sandbox): avoid nested proxy netns setup for subagent commands#12618
Closed
viyatb-oai wants to merge 7 commits intomainfrom
Closed
fix(linux-sandbox): avoid nested proxy netns setup for subagent commands#12618viyatb-oai wants to merge 7 commits intomainfrom
viyatb-oai wants to merge 7 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0638857fd2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…572-nested-proxy-netns-fallback # Conflicts: # MODULE.bazel.lock
…572-nested-proxy-netns-fallback
This was referenced Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12572
Summary
On some Linux environments (notably Ubuntu 24.04 with stricter namespace/AppArmor defaults), sandboxed subagent commands can fail before execution with a bubblewrap loopback/network-namespace setup error.
This change adds a targeted fallback for nested sandbox executions:
Why
The failure happens during nested Linux sandbox initialization, even for trivial commands like
pwdorls, because the command fails before the user command starts.Scope
Validation
just fmtcargo test -p codex-linux-sandboxcargo clippy -p codex-linux-sandbox --all-targets -- -D warnings