Skip to content

Enable request_user_input in Default mode#12706

Closed
charley-oai wants to merge 9 commits intomainfrom
codex-worktree-too
Closed

Enable request_user_input in Default mode#12706
charley-oai wants to merge 9 commits intomainfrom
codex-worktree-too

Conversation

@charley-oai
Copy link
Collaborator

Summary

  • allow request_user_input in Default collaboration mode as well as Plan
  • update the Default-mode instructions to prefer assumptions first and use request_user_input only when a question is unavoidable
  • update request_user_input and app-server tests to match the new Default-mode behavior

Testing

  • just fmt
  • cargo test -p codex-protocol
  • cargo test -p codex-core request_user_input
  • cargo test -p codex-app-server turn_start_accepts_collaboration_mode_override_v2

@charley-oai
Copy link
Collaborator Author

@codex review this

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c9a5138b67

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai
Copy link
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai
Copy link
Collaborator Author

@codex review this

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

let items = thread_manager.list_collaboration_modes();

P2 Badge Make collaboration mode list honor thread feature overrides

list_collaboration_modes always returns presets from ThreadManager's startup config. But thread/start can override features.default_mode_request_user_input per thread, so the returned developer_instructions can contradict that thread’s real request_user_input availability. If a client reuses these instructions (non-None), normalize_turn_start_collaboration_mode won’t rewrite them, leaving stale guidance in prompts.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai
Copy link
Collaborator Author

Superseded by #12735 so the active PR uses branch collaboration-modes-config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant