feat(app-server): add ThreadItem::DynamicToolCall#12732
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0e1279e24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Add EventMsg::DynamicToolCallResponse to the large match in run_codex_tool_session. This commit introduces a new EventMsg variant, but this exhaustive match still enumerates DynamicToolCallRequest only. Building codex-mcp-server against the updated codex-protocol will fail with a non-exhaustive pattern error.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Previously, clients would call
thread/startwith dynamic_tools set, and when a model invokes a dynamic tool, it would just make the server->clientitem/tool/callrequest and wait for the client's response to complete the tool call. This works, but it doesn't have anitem/startedoritem/completedevent.Now we are doing this:
item/startedwithDynamicToolCallpopulated with the call argumentsitem/tool/callserver requestitem/completedwithDynamicToolCallpopulated with the response.Also, with
persistExtendedHistory: true, dynamic tool calls are now reconstructable inthread/readandthread/resumeasThreadItem::DynamicToolCall.