tui: align pending steers with core acceptance by charley-oai · Pull Request #12868 · openai/codex

charley-oai · 2026-02-26T05:20:45Z

Summary

submit Enter steers immediately while a turn is already running instead of routing them through queued_user_messages
keep those submitted steers visible in the footer as pending_steers until core records them as a user message or aborts the turn
reconcile pending steers on ItemCompleted(UserMessage), not RawResponseItem
emit user-message item lifecycle for leftover pending input at task finish, then remove the TUI TurnComplete fallback
keep queued_user_messages for actual queued drafts, rendered below pending steers

Problem

While the assistant was generating, pressing Enter could send the input into queued_user_messages. That queue only drains after the turn ends, so ordinary steers behaved like queued drafts instead of landing at the next core sampling boundary.

The first version of this fix also used RawResponseItem to decide when a steer had landed. Review feedback was that this is the wrong abstraction for client behavior.

There was also a late edge case in core: if pending steer input was accepted after the final sampling decision but before TurnComplete, core would record that user message into history at task finish without emitting ItemStarted(UserMessage) / ItemCompleted(UserMessage). TUI had a fallback to paper over that gap locally.

Approach

Enter during an active turn now submits a normal Op::UserTurn immediately
TUI keeps a local pending-steer preview instead of rendering that user message into history immediately
when core records the steer as ItemCompleted(UserMessage), TUI matches and removes the corresponding pending preview, then renders the committed user message
core now emits the same user-message lifecycle when on_task_finished(...) drains leftover pending user input, before TurnComplete
with that lifecycle gap closed in core, TUI no longer needs to flush pending steers into history on TurnComplete
if the turn is interrupted, pending steers and queued drafts are both restored into the composer, with pending steers first

Notes

Tab still uses the real queued-message path
queued_user_messages and pending_steers are separate state with separate semantics
the pending-steer matching key is built directly from UserInput
this removes the new TUI dependency on RawResponseItem

Codex author

codex resume 019c9259-8b56-7b02-9528-57c81c76c67d

charley-oai · 2026-02-26T06:44:05Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ee6428600

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-02-26T08:52:58Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c826289d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-02-26T20:53:05Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 12eed0f18d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-02-27T00:19:43Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 32eec29d04

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-02-27T04:15:06Z

...hots/codex_tui__chatwidget__tests__deltas_then_same_final_message_are_rendered_snapshot.snap

-source: tui/src/chatwidget/tests.rs
-expression: combined
---
-• Here is the result.


This test was specifically exercising AgentMessageDelta* followed by a duplicate legacy EventMsg::AgentMessage

That is not the live path we want to preserve anymore

Keeping it would just pin stale compatibility behavior into the PR

charley-oai · 2026-02-27T04:42:36Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/tui/src/chatwidget.rs

Lines 1469 to 1470 in ce92e5a

    
           if !from_replay && self.queued_user_messages.is_empty() { 
        
               self.maybe_prompt_plan_implementation();

Gate plan-implementation prompt on pending nudges

on_task_complete now decides whether to show the plan-implementation prompt using only queued_user_messages.is_empty(). After this change, Enter-during-turn submissions are moved to pending_nudges, so the queue is empty even when a follow-up was already sent. That can incorrectly pop the implementation prompt at turn end despite pending/just-submitted nudges.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai · 2026-02-27T07:38:43Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 291fea2ed3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-02-27T20:24:37Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/tui/src/chatwidget.rs

Lines 1492 to 1493 in 1af49bb

    
           if !self.queued_user_messages.is_empty() { 
        
               return;

Block plan follow-up popup while nudges are pending

Plan follow-up prompting still checks only queued_user_messages. After this change, Enter-during-turn submissions are stored in pending_nudges instead, so maybe_prompt_plan_implementation can fire even though the user already submitted a nudge that has not been committed yet. This can show an incorrect "implement plan" prompt.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-02-27T21:29:07Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 39a9c3b658

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-03-02T20:35:46Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5590cc39dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-03-03T00:13:26Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3e56682ed7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-03-03T03:13:43Z

@codex review this

charley-oai · 2026-03-03T00:26:04Z

codex-rs/core/src/tasks/mod.rs

+                    )
+                    .await;
+                }
+            }


Small core bugfix to emit ItemStarted(UserMessage)/ItemCompleted(UserMessage) for leftover pending user input at task finish (so we can rely on ItemCompleted(UserMessage) for core user message acceptance in all cases.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 119ca71e8f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-03-03T03:30:38Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2fc7bb32d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

codex-rs/tui/src/chatwidget/realtime.rs

charley-oai · 2026-03-03T04:42:38Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/tui/src/chatwidget.rs

Lines 4536 to 4537 in 1ef1206

    
           TurnAbortReason::Replaced => { 
        
               self.on_error("Turn aborted: replaced by a new task".to_owned())

Clear pending steers on replaced-turn abort

TurnAbortReason::Replaced routes to on_error(...) only, unlike interrupt paths that drain/restore pending input. When a task is replaced, core clears pending input, so pending_steers can no longer be matched by later ItemCompleted(UserMessage) events. They remain stuck in the footer and can suppress follow-up plan prompting.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai · 2026-03-03T06:28:31Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3e778b4a50

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-03-03T07:08:11Z

@codex review this

chatgpt-codex-connector · 2026-03-03T07:21:18Z

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aibrahim-oai · 2026-03-03T23:14:39Z

codex-rs/core/src/tasks/mod.rs

+                } else {
+                    self.record_conversation_items(
+                        turn_context.as_ref(),
+                        std::slice::from_ref(&response_item),


will be recording this twice?

Hmm no it's just recorded once?

ah it's if/else

I don't like how the code is looking but I see why. Can we leave a comment here?

charley-oai force-pushed the tui-pending-nudges-message-boundary branch from 653dd24 to 3ee6428 Compare February 26, 2026 05:52

chatgpt-codex-connector bot reviewed Feb 26, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

github-actions bot mentioned this pull request Feb 26, 2026

📊 AI CLI 工具社区动态日报 2026-02-26 duanyytop/agents-radar#14

Open

chatgpt-codex-connector bot reviewed Feb 26, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

github-actions bot mentioned this pull request Feb 26, 2026

📊 AI CLI 工具社区动态日报 2026-02-26 duanyytop/agents-radar#17

Open

chatgpt-codex-connector bot reviewed Feb 26, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

charley-oai changed the title ~~tui: submit pending nudges after message boundaries~~ tui: align pending nudges with core acceptance Feb 27, 2026

charley-oai commented Feb 27, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Show resolved Hide resolved

github-actions bot mentioned this pull request Feb 28, 2026

📊 AI CLI 工具社区动态日报 2026-02-28 duanyytop/agents-radar#23

Open

charley-oai changed the title ~~tui: align pending nudges with core acceptance~~ tui: align pending steers with core acceptance Mar 2, 2026

chatgpt-codex-connector bot reviewed Mar 2, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

charley-oai added 4 commits March 2, 2026 16:13

tui: submit pending nudges after message boundaries

dbb69dd

tui: rename pending input preview

1d5cad0

tui: rename preview snapshots

985283b

tui: format rebased bottom pane imports

253eeb1

chatgpt-codex-connector bot reviewed Mar 3, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Show resolved Hide resolved

tui: scope pending steers away from review mode

119ca71

charley-oai commented Mar 3, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 3, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

tui: replay review agent messages in thread snapshots

2fc7bb3

chatgpt-codex-connector bot reviewed Mar 3, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Show resolved Hide resolved

codex-rs/tui/src/chatwidget/realtime.rs Outdated Show resolved Hide resolved

tui: use lightweight pending steer compare keys

1ef1206

charley-oai added 2 commits March 2, 2026 20:45

tui: share pending steer compare key logic

2dfc7a2

tui: format chatwidget imports

d25b311

chatgpt-codex-connector bot reviewed Mar 3, 2026

View reviewed changes

tui: clear pending steers on replaced turns

3e778b4

chatgpt-codex-connector bot reviewed Mar 3, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Show resolved Hide resolved

codex-rs/tui/src/chatwidget.rs Show resolved Hide resolved

tui: preserve pending steer metadata on commit

4276ff1

github-actions bot mentioned this pull request Mar 3, 2026

📊 AI CLI 工具社区动态日报 2026-03-03 duanyytop/agents-radar#55

Closed

This was referenced Mar 3, 2026

📊 AI CLI 工具社区动态日报 2026-03-03 duanyytop/agents-radar#60

Closed

📊 AI CLI 工具社区动态日报 2026-03-03 duanyytop/agents-radar#65

Open

tui: avoid expect in pending steer pop

db4f757

aibrahim-oai reviewed Mar 3, 2026

View reviewed changes

aibrahim-oai approved these changes Mar 3, 2026

View reviewed changes

core: clarify leftover pending input lifecycle

875d227

charley-oai merged commit 299b8ac into main Mar 3, 2026
29 of 30 checks passed

charley-oai deleted the tui-pending-nudges-message-boundary branch March 3, 2026 23:31

github-actions bot locked and limited conversation to collaborators Mar 3, 2026

charley-oai restored the tui-pending-nudges-message-boundary branch March 18, 2026 04:36

	if !from_replay && self.queued_user_messages.is_empty() {
	self.maybe_prompt_plan_implementation();

	TurnAbortReason::Replaced => {
	self.on_error("Turn aborted: replaced by a new task".to_owned())

Conversation

charley-oai commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Approach

Notes

Codex author

Uh oh!

charley-oai commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

charley-oai commented Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

charley-oai commented Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Mar 2, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Mar 3, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

charley-oai commented Feb 26, 2026 •

edited

Loading