Merged
Conversation
mousseau-oai
force-pushed
the
dev/mousseau/app-server-permissions
branch
from
3e08337 to
4fbb6d0
Compare
This was referenced Mar 2, 2026
mousseau-oai
force-pushed
the
dev/mousseau/app-server-permissions
branch
from
4fbb6d0 to
22730c4
Compare
mousseau-oai
force-pushed
the
dev/mousseau/app-server-permissions
branch
from
22730c4 to
d5aab71
Compare
dylan-hurd-oai
approved these changes
Mar 7, 2026
Collaborator
dylan-hurd-oai
left a comment
dylan-hurd-oai
left a comment
There was a problem hiding this comment.
Some non-blocking comments, would be great to clean these up but excited to get this in!
mousseau-oai
force-pushed
the
dev/mousseau/app-server-permissions
branch
from
d5aab71 to
bd80d69
Compare
Contributor
Author
|
Introduced new |
mousseau-oai
force-pushed
the
dev/mousseau/app-server-permissions
branch
from
bd80d69 to
e44e268
Compare
mousseau-oai
force-pushed
the
dev/mousseau/app-server-permissions
branch
from
154fc02 to
d385071
Compare
dylan-hurd-oai
approved these changes
Mar 8, 2026
This was referenced Mar 9, 2026
mousseau-oai
force-pushed
the
dev/mousseau/app-server-permissions
branch
from
8f16035 to
3e783b2
Compare
mousseau-oai
force-pushed
the
dev/mousseau/app-server-permissions
branch
from
074865d to
8ed80f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a built-in
request_permissionstool and wires it through the Codex core, protocol, and app-server layers so a running turn can ask the client for additional permissions instead of relying on a static session policy.The new flow emits a
RequestPermissionsevent from core, tracks the pending request by call ID, forwards it through app-server v2 as anitem/permissions/requestApprovalrequest, and resumes the tool call once the client returns an approved subset of the requested permission profile.