Feat: Preserve network access on read-only sandbox policies#13409
Merged
Feat: Preserve network access on read-only sandbox policies#13409
Conversation
adf0d51 to
24e0c67
Compare
24e0c67 to
277998c
Compare
bolinfest
reviewed
Mar 4, 2026
bolinfest
reviewed
Mar 4, 2026
bolinfest
approved these changes
Mar 4, 2026
dylan-hurd-oai
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PermissionProfile.networkcould not be preserved when additional or compiled permissions resolved toSandboxPolicy::ReadOnly, becauseReadOnlyhad no network_access field. This change makes read-only + networkenabled representable directly and threads that through the protocol, app-server v2 mirror, and permission-
merging logic.
What changed
network_access: booltoSandboxPolicy::ReadOnlyin the core protocol and app-server v2 protocol.deserialize unchanged.
has_full_network_access()and sandbox summaries to respect read-only network access.