Prefer websockets when providers support them#13592
Merged
pakrym-oai merged 16 commits intomainfrom Mar 18, 2026
Merged
Conversation
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
sayan-oai
approved these changes
Mar 5, 2026
Collaborator
sayan-oai
left a comment
sayan-oai
left a comment
There was a problem hiding this comment.
small comment about dead args in test helper
Remove unused websocket feature flag wiring in client websocket tests and drop the redundant config wire API test. Unify TypeScript SDK tests codex home handling via Jest setup, export and reuse codexExecPath, and rely on per-test temporary CODEX_HOME instead of requiring it to be preset.
Co-authored-by: Codex <noreply@openai.com>
…websockets-field # Conflicts: # codex-rs/app-server/tests/common/config.rs # codex-rs/app-server/tests/suite/v2/compaction.rs # codex-rs/core/models.json # codex-rs/core/src/client.rs # codex-rs/core/src/codex.rs # codex-rs/core/src/config/mod.rs # codex-rs/core/tests/common/test_codex.rs # codex-rs/core/tests/suite/client.rs # codex-rs/core/tests/suite/client_websockets.rs # sdk/typescript/tests/run.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all flags and model settings.