Skip to content

Add timestamped SQLite /feedback logs without schema changes#13645

Merged
charley-oai merged 2 commits intomainfrom
cc/sqlite-feedback-starter-no-migration
Mar 6, 2026
Merged

Add timestamped SQLite /feedback logs without schema changes#13645
charley-oai merged 2 commits intomainfrom
cc/sqlite-feedback-starter-no-migration

Conversation

@charley-oai
Copy link
Collaborator

Summary

  • keep the SQLite schema unchanged (no migrations)
  • add timestamps to SQLite-backed /feedback log exports
  • keep the existing SQL-side byte cap behavior and newline handling
  • document the remaining fidelity gap (span prefixes + structured fields) with TODOs

Details

  • update query_feedback_logs to format each exported line as:
    • YYYY-MM-DDTHH:MM:SS.ffffffZ {level} {message}
  • continue scoping rows to requested-thread + same-process threadless logs
  • continue capping in SQL before returning rows
  • keep the existing fallback behavior unchanged when SQLite returns no rows
  • update parity tests to normalize away the new timestamp prefix while we still only store message

Follow-up

  • TODO already in code: persist enough span/event metadata in SQLite to reproduce span prefixes and structured fields in /feedback exports

Testing

  • cargo test -p codex-state
  • just fmt

charley-oai and others added 2 commits March 5, 2026 16:12
Keep the existing logs schema and include RFC3339 microsecond timestamps in query_feedback_logs output.

Document the remaining parity gap (span prefixes and structured fields) with TODOs and update feedback export tests accordingly.

Co-authored-by: Codex <noreply@openai.com>
@charley-oai
Copy link
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai merged commit 9f91c7f into main Mar 6, 2026
29 of 31 checks passed
@charley-oai charley-oai deleted the cc/sqlite-feedback-starter-no-migration branch March 6, 2026 00:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants