Skip to content

fix: reject global wildcard network proxy domains#13789

Merged
viyatb-oai merged 3 commits intomainfrom
codex/viyatb/remove-network-proxy-global-wildcard
Mar 6, 2026
Merged

fix: reject global wildcard network proxy domains#13789
viyatb-oai merged 3 commits intomainfrom
codex/viyatb/remove-network-proxy-global-wildcard

Conversation

@viyatb-oai
Copy link
Collaborator

@viyatb-oai viyatb-oai commented Mar 6, 2026

Summary

  • reject the global * domain pattern in proxy allow/deny lists and managed constraints introduced for testing earlier
  • keep exact hosts plus scoped wildcards like *.example.com and **.example.com
  • update docs and regression tests for the new invalid-config behavior

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df83167701

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link

@rreichel3-oai rreichel3-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@viyatb-oai viyatb-oai enabled auto-merge (squash) March 6, 2026 20:50
@viyatb-oai viyatb-oai merged commit 9a4787c into main Mar 6, 2026
31 checks passed
@viyatb-oai viyatb-oai deleted the codex/viyatb/remove-network-proxy-global-wildcard branch March 6, 2026 21:06
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants