fix: avoid invoking git before project trust is established#13804
Merged
viyatb-oai merged 1 commit intomainfrom Mar 7, 2026
Merged
fix: avoid invoking git before project trust is established#13804viyatb-oai merged 1 commit intomainfrom
viyatb-oai merged 1 commit intomainfrom
Conversation
pakrym-oai
approved these changes
Mar 7, 2026
Collaborator
|
This looks good, though my one post-commit piece of feedback is that the docstring (or some comment in the code) should explain that we are deliberately avoiding running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitentries on disk instead of spawninggit rev-parse --git-common-dirTesting
just fmtcargo test -p codex-core resolve_root_git_project_for_trustcargo clippy -p codex-core --all-targets -- -D warningscargo test -p codex-core(fails in this environment on unrelated managed-configDangerFullAccesstests incodex::tests,tools::js_repl::tests, andunified_exec::tests)