Add granular metrics for cloud requirements load#14108
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5793271d83
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| CLOUD_REQUIREMENTS_AUTH_RECOVERY_FAILED_MESSAGE, | ||
| )); | ||
| }; | ||
| auth = refreshed_auth; |
There was a problem hiding this comment.
After a 401, the auth-recovery success path reuses the same attempt value and immediately continues. This emits duplicate fetch_attempt metrics with the same attempt tag and records fetch_final.attempt_count as 1 even when two backend requests were made. The new granular metrics undercount real retry behavior.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
so you will see a failed follow by a succeeded? Can we have a metric based on the final result?
There was a problem hiding this comment.
We have CLOUD_REQUIREMENTS_FETCH_FINAL_METRIC which is the final result. This comment is for this per attempt metric: CLOUD_REQUIREMENTS_FETCH_ATTEMPT_METRIC
2 participants
No description provided.