Mark incomplete resumed turns interrupted when idle#14125
Merged
guinness-oai merged 4 commits intomainfrom Mar 10, 2026
Merged
Conversation
euroelessar
reviewed
Mar 9, 2026
Comment on lines
+3255
to
+3259
| for turn in &mut thread.turns { | ||
| if matches!(turn.status, TurnStatus::InProgress) { | ||
| turn.status = TurnStatus::Interrupted; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I think this check/rewrite needs to be done before resume_thread_with_history call above.
We do allow multiple clients to connect to the same app server, and they should observe the same thread status/etc, but with this change only the first connected client will see interrupted turns, the rest will be stuck in limbo as before this change.
euroelessar
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a Codex app bug where quitting the app mid-run could leave the reopened thread stuck in progress and non-interactable. On cold thread resume, app-server could return an idle thread with a replayed turn still marked in progress. This marks incomplete replayed turns as interrupted unless the thread is actually active.