Merged
Conversation
aibrahim-oai
force-pushed
the
dev/spawn-agent-model-overrides
branch
from
037fd1f to
a0a9fc6
Compare
aibrahim-oai
force-pushed
the
dev/spawn-agent-model-overrides
branch
from
a50fd12 to
46a3a7c
Compare
pakrym-oai
approved these changes
Mar 10, 2026
Collaborator
pakrym-oai
left a comment
pakrym-oai
left a comment
There was a problem hiding this comment.
The product change looks reasonable but the test change seems excessively custom. Can we reuse existing sub agent tests?
pakrym-oai
reviewed
Mar 10, 2026
| } | ||
| } | ||
|
|
||
| async fn apply_requested_spawn_agent_model_overrides( |
Collaborator
There was a problem hiding this comment.
the fact that all this code needs to be written is a bit sad. our internal agent api is cumbersome
pakrym-oai
reviewed
Mar 10, 2026
| ) -> Result<String, FunctionCallError> { | ||
| available_models | ||
| .iter() | ||
| .find(|model| model.model == requested_model || model.id == requested_model) |
Collaborator
There was a problem hiding this comment.
why are we checking id?
aibrahim-oai
force-pushed
the
dev/spawn-agent-model-overrides
branch
from
eb18ad1 to
e639866
Compare
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modelandreasoning_effortto thespawn_agentschema so the values pass throughmodel.modeland only check that the selected model supports the requested reasoning effort