Add plugin usage telemetry by alexsong-oai · Pull Request #14531 · openai/codex

alexsong-oai · 2026-03-12T23:57:08Z

adding metrics including:

plugin used
plugin installed/uninstalled
plugin enabled/disabled

alexsong-oai · 2026-03-13T00:14:11Z

xl-openai · 2026-03-13T00:18:49Z

codex-rs/core/src/plugins/toggles.rs

+}
+
+pub fn plugin_toggle_events_to_emit(
+    previous_states: &BTreeMap<String, Option<bool>>,


Can we simplify the logic by no checking previous_status?

We need the previous state to make sure it’s actually an update?

I think it’s already checked by the UI, except for a minimal race condition.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 53869eac13

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/app-server/src/config_api.rs

xl-openai · 2026-03-13T00:20:38Z

codex-rs/app-server/src/message_processor.rs

+            AnalyticsEventsClient::new(Arc::clone(&config), Arc::clone(&auth_manager));
+        thread_manager
+            .plugins_manager()
+            .set_analytics_events_client(analytics_events_client.clone());


why not just set it when you init plugin_manager?

alexsong-oai · 2026-03-13T00:49:04Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e867bbcf12

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/thread_manager.rs

codex-rs/core/src/plugins/manager.rs

alexsong-oai · 2026-03-13T01:34:22Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5275b98cb3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-13T01:44:10Z

codex-rs/core/src/plugins/manager.rs

+    let mut mcp_server_names = manifest_paths
+        .mcp_servers
+        .as_ref()
+        .map(|path| {
+            load_mcp_servers_from_file(plugin_root, path)
+                .mcp_servers
+                .into_keys()
+                .collect::<Vec<_>>()
+        })
+        .unwrap_or_default();


Include default MCP servers in plugin telemetry

plugin_telemetry_metadata_from_root only reads MCP servers when manifest_paths.mcp_servers is set. Plugins that rely on the default .codex-plugin/mcp-servers.json path are reported with mcp_server_count = 0, so install/uninstall/enable/disable analytics undercount capabilities compared with actual plugin loading behavior.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-13T01:44:10Z

codex-rs/core/src/plugins/toggles.rs

+            [plugins, plugin_id] if plugins == "plugins" => {
+                if let Some(enabled) = value.get("enabled").and_then(JsonValue::as_bool) {
+                    pending_changes.insert(plugin_id.clone(), enabled);
+                }


Clear stale plugin-toggle candidates on null edits

collect_plugin_enabled_candidates only inserts when an enabled bool is present and ignores clear-path edits (value = null). In batch writes applied sequentially, a later clear of the same plugin key can leave an earlier candidate in the map, causing codex_plugin_enabled/disabled events that do not match the final config state.

Useful? React with 👍 / 👎.

this should be fine

alexsong-oai · 2026-03-13T01:54:47Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77a6e0f079

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/plugins/toggles.rs

codex-rs/app-server/src/config_api.rs

alexsong-oai added 2 commits March 12, 2026 16:55

Add plugin usage telemetry

262ecd1

updates

53869ea

minor

0e0fc9d

xl-openai reviewed Mar 13, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

codex-rs/app-server/src/config_api.rs Outdated Show resolved Hide resolved

xl-openai reviewed Mar 13, 2026

View reviewed changes

alexsong-oai added 3 commits March 12, 2026 17:36

inject analytics_manager

3db6995

updates

315ae14

fixt

e867bbc

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

codex-rs/core/src/thread_manager.rs Outdated Show resolved Hide resolved

codex-rs/core/src/plugins/manager.rs Outdated Show resolved Hide resolved

github-actions bot mentioned this pull request Mar 13, 2026

📊 AI CLI 工具社区动态日报 2026-03-13 gsscsd/big_model_radar#27

Open

alexsong-oai added 4 commits March 12, 2026 18:02

remove prev state

2a63318

clean

0265a0a

clean

504dc17

minor

5275b98

xl-openai approved these changes Mar 13, 2026

View reviewed changes

fix test

262011d

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

mcp servers

77a6e0f

github-actions bot mentioned this pull request Mar 13, 2026

📊 Bản tin hàng ngày công cụ AI CLI 2026-03-13 compasify/agents-radar#35

Open

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

codex-rs/core/src/plugins/toggles.rs Show resolved Hide resolved

codex-rs/app-server/src/config_api.rs Show resolved Hide resolved

alexsong-oai merged commit 1a363d5 into main Mar 13, 2026
32 checks passed

alexsong-oai deleted the alexs/plugins-analytics branch March 13, 2026 02:22

github-actions bot locked and limited conversation to collaborators Mar 13, 2026

Conversation

alexsong-oai commented Mar 12, 2026

Uh oh!

alexsong-oai commented Mar 13, 2026

Uh oh!

xl-openai Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

alexsong-oai Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

xl-openai Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

xl-openai Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

alexsong-oai commented Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

alexsong-oai commented Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

alexsong-oai Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

alexsong-oai commented Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants