[apps] Improve search tool fallback.#14732
Merged
mzeng-openai merged 2 commits intomainfrom Mar 16, 2026
Merged
Conversation
Collaborator
mzeng-openai
commented
Mar 15, 2026
mzeng-openai
commented
- Bypass tool search and stuff tool specs directly into model context when either a. Tool search is not available for the model or b. There are not that many tools to search for.
mzeng-openai
requested review from
apanasenko-oai,
pakrym-oai and
sayan-oai
and removed request for
apanasenko-oai
| let expose_app_tools_directly = !turn_context.tools_config.search_tool | ||
| || app_tools | ||
| .as_ref() | ||
| .is_some_and(|tools| tools.len() < DIRECT_APP_TOOL_EXPOSURE_THRESHOLD); |
Collaborator
There was a problem hiding this comment.
if we want to use threshold as way to disable search tool, we need to move it to turn_context.tools_config.search_tool otherwise we will have situation when we have search tool and tools injected into context.
Collaborator
Author
There was a problem hiding this comment.
Tool search will not be enabled if app_tools is empty:
codex/codex-rs/core/src/tools/spec.rs
Line 2734 in 49edf31
Collaborator
There was a problem hiding this comment.
ah, I see, I would love this logic be much simpler since it hard to keep in mind all this invariants.
This was referenced Mar 16, 2026
apanasenko-oai
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.