Merged
Conversation
…otification-injection
…otification-injection # Conflicts: # codex-rs/core/src/tools/code_mode/runner.cjs # codex-rs/core/tests/suite/code_mode.rs
Introduce ResponseInputItem::Notification and ResponseItem::Notification carrying FunctionCallOutputPayload. Treat notifications like function outputs across context management, compaction, telemetry, timing, and JS REPL summaries, but do not persist them as memories. Update code mode notify to inject notification items instead of developer messages and adjust tests and documentation accordingly. Add serialization/deserialization tests for notification items.
cconger
approved these changes
Mar 18, 2026
Contributor
cconger
left a comment
cconger
left a comment
There was a problem hiding this comment.
One question about second channel.
…otification-injection # Conflicts: # codex-rs/app-server-protocol/schema/typescript/ResponseItem.ts # codex-rs/protocol/src/models.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows model to send an out-of-band notification.
The notification is injected as another tool call output for the same call_id.