Skip to content

fix: align marketplace display name with existing interface conventions#14886

Merged
xl-openai merged 1 commit intomainfrom
xl/plugins
Mar 17, 2026
Merged

fix: align marketplace display name with existing interface conventions#14886
xl-openai merged 1 commit intomainfrom
xl/plugins

Conversation

@xl-openai
Copy link
Copy Markdown
Collaborator

  1. camelCase for displayName;
  2. move displayName under interface.

@xl-openai xl-openai requested a review from gverma-openai March 17, 2026 04:25
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 30d853d808

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +375 to 380
#[serde(rename_all = "camelCase")]
struct MarketplaceFile {
name: String,
#[serde(default)]
#[serde(alias = "displayName")]
display_name: Option<String>,
interface: Option<MarketplaceInterface>,
plugins: Vec<MarketplacePlugin>,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve legacy marketplace display-name parsing

Keep backward compatibility when reading marketplace.json. This change removes the top-level display_name/displayName field parser and only reads interface.displayName, so existing marketplace files from prior versions will silently lose their display label and API responses will return interface: null.

Useful? React with 👍 / 👎.

@xl-openai xl-openai merged commit e5a28ba into main Mar 17, 2026
33 checks passed
@xl-openai xl-openai deleted the xl/plugins branch March 17, 2026 04:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants