-
Notifications
You must be signed in to change notification settings - Fork 10.9k
Expand ~ in MDM workspace write roots #15351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+99
−1
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
19fe0f3
config: support tilde paths in MDM config
evawong-oai 3fb2305
config: validate merged MDM paths consistently
evawong-oai a4395c5
Apply suggestions from code review
bolinfest af32762
config: address review feedback
evawong-oai d806b22
test: cover parent-relative instructions file
evawong-oai 9bf2595
test: widen windows multi-agent timing budget
evawong-oai 4e276a5
test: avoid noexec tempdir for fake bwrap
evawong-oai 4b2abff
config: make home expansion MDM-specific
evawong-oai 97998da
config: scope tilde expansion to MDM writable_roots
evawong-oai 74fda24
config: reuse existing resolver for MDM tilde paths
evawong-oai 0d84574
test: accept zsh-fork decline timeout output
evawong-oai 67d15b5
test: deflake current CI failures
evawong-oai 7c8c565
test: drop windows-specific plugin_read timeout
evawong-oai cba7a5e
revert: drop unrelated CI deflakes
evawong-oai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm debating whether we should do this or bring back your alternative path guard that honors
~but not./.This is certainly simpler.
I don't know if there's a valid use case to specify a relative path in an MDM config. In the worst case, it could be an attack vector, but because MDM should be set by a trusted person, I guess I'm not that worried about that.
Maybe please just add a comment that we use
codex_homeas the base so that~and./are honored using ourAbsolutePathBufGuardlogic, though in practice, we expect~to be used but not./.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Following up with a comment.