Move string truncation helpers into codex-utils-string by aibrahim-oai · Pull Request #15572 · openai/codex

aibrahim-oai · 2026-03-23T22:25:15Z

move the shared byte-based middle truncation logic from core into codex-utils-string
keep token-specific truncation in codex-core so rollout can reuse the shared helper in the next stacked PR

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai · 2026-03-24T03:03:17Z

@codex review this

aibrahim-oai · 2026-03-24T03:05:48Z

@codex review this

chatgpt-codex-connector · 2026-03-24T03:11:18Z

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai · 2026-03-24T03:21:24Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 333051d7bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-24T03:31:12Z

+    Some(MiddleTruncation {
+        prefix,
+        suffix,
+        removed_bytes: s.len().saturating_sub(max_bytes),


Derive removed_bytes from retained slices, not budget

removed_bytes is set to s.len() - max_bytes, but UTF-8 boundary preservation can retain fewer than max_bytes bytes. This undercounts removals for multibyte text (e.g. 4 emojis with max_bytes=14 removes 8 bytes but reports 2). truncate_middle_with_token_budget then underreports removed_tokens because it relies on this field. Compute removals from prefix.len() and suffix.len() instead.

Useful? React with 👍 / 👎.

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai · 2026-03-24T14:59:35Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 918fbba026

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai · 2026-03-24T17:09:43Z

@review and make sure no behavioral changes.

Co-authored-by: Codex <noreply@openai.com>

bolinfest · 2026-03-24T22:03:58Z

+    out
+}
+
+#[cfg(test)]


why not path = truncate_tests.rs

aibrahim-oai force-pushed the codex/extract-git-utils-crate branch from 56b3e16 to 12948a4 Compare March 23, 2026 23:34

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch 2 times, most recently from c62c328 to 5ed93d4 Compare March 23, 2026 23:37

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: rename leftover truncation files on PR #15572

9401d05

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: rename leftover truncation files on PR #15572

b8a17ba

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from 9401d05 to b8a17ba Compare March 24, 2026 00:16

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: rename leftover truncation files on PR #15572

a28046a

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from b8a17ba to a28046a Compare March 24, 2026 00:22

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: rename leftover truncation files on PR #15572

9e2a887

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from a28046a to 9e2a887 Compare March 24, 2026 00:34

github-actions bot mentioned this pull request Mar 24, 2026

📊 AI CLI 工具社区动态日报 2026-03-24 gsscsd/big_model_radar#86

Open

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from 9e2a887 to 8aca7f8 Compare March 24, 2026 01:47

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: rename leftover truncation files on PR #15572

8aca7f8

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: rename leftover truncation files on PR #15572

fda1492

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from 8aca7f8 to fda1492 Compare March 24, 2026 02:05

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: rename leftover truncation files on PR #15572

4bf0fbc

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from fda1492 to 4bf0fbc Compare March 24, 2026 02:13

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: rename leftover truncation files on PR #15572

8a0da2e

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from 4bf0fbc to 8a0da2e Compare March 24, 2026 02:24

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: rename leftover truncation files on PR #15572

e66ce7d

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from 8a0da2e to e66ce7d Compare March 24, 2026 02:29

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: rename leftover truncation files on PR #15572

56f37f8

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from e66ce7d to 56f37f8 Compare March 24, 2026 03:16

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: rename leftover truncation files on PR #15572

333051d

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from 56f37f8 to 333051d Compare March 24, 2026 03:18

chatgpt-codex-connector bot reviewed Mar 24, 2026

View reviewed changes

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from 3b6fddc to 918fbba Compare March 24, 2026 14:57

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: reduce truncate move churn on PR #15572

f3a3fcc

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: move truncation into protocol on PR #15572

6e0d71b

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix truncation stack CI on PR #15572

5d76eda

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15572

feefae0

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15572

6a6e7f9

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15572

a560406

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix clippy on PR #15572

1ac1cf6

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15572

32df8d8

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15572

ae7b86b

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: suppress truncation test warnings on PR #15572

83d1fbf

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: remove core truncation test shim on PR #15572

9e66430

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix clippy warning on PR #15572

d1368bf

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15572

a74ef29

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15572

8d6c44b

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: remove lint suppression from PR #15572

918fbba

Co-authored-by: Codex <noreply@openai.com>

chatgpt-codex-connector bot reviewed Mar 24, 2026

View reviewed changes

Comment thread codex-rs/protocol/src/output_truncation.rs Outdated

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: restore moved-module lint suppression on PR #15572

8235bbe

Co-authored-by: Codex <noreply@openai.com>

Base automatically changed from codex/extract-git-utils-crate to main March 24, 2026 20:26

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from cf6ff4f to eae882e Compare March 24, 2026 21:22

Move string truncation helpers into codex-utils-string

94b0e35

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from 7ea10d9 to 94b0e35 Compare March 24, 2026 21:34

bolinfest approved these changes Mar 24, 2026

View reviewed changes

Comment thread codex-rs/utils/string/src/truncate.rs

out

}

#[cfg(test)]

Copy link
Copy Markdown

Collaborator

bolinfest Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not path = truncate_tests.rs

aibrahim-oai added 2 commits March 24, 2026 15:23

feedback

445af84

feedback

c9453e8

aibrahim-oai merged commit 062fa7a into main Mar 24, 2026
39 of 42 checks passed

aibrahim-oai deleted the codex/extract-string-truncation-utils branch March 24, 2026 22:45

github-actions bot locked and limited conversation to collaborators Mar 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move string truncation helpers into codex-utils-string#15572

Move string truncation helpers into codex-utils-string#15572
aibrahim-oai merged 3 commits intomainfrom
codex/extract-string-truncation-utils

aibrahim-oai commented Mar 23, 2026

Uh oh!

aibrahim-oai commented Mar 24, 2026

Uh oh!

aibrahim-oai commented Mar 24, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 24, 2026

Uh oh!

aibrahim-oai commented Mar 24, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 24, 2026

Uh oh!

aibrahim-oai commented Mar 24, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

aibrahim-oai commented Mar 24, 2026

Uh oh!

bolinfest Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

aibrahim-oai commented Mar 23, 2026

Uh oh!

aibrahim-oai commented Mar 24, 2026

Uh oh!

aibrahim-oai commented Mar 24, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 24, 2026

Uh oh!

aibrahim-oai commented Mar 24, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

aibrahim-oai commented Mar 24, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

aibrahim-oai commented Mar 24, 2026

Uh oh!

bolinfest Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants