Conversation
3ba3e0d to
0b5177a
Compare
pakrym-oai
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
shell-tool-mcpand the Bash fork are no longer needed, but the patched zsh fork is still relevant for shell escalation and for the DotSlash-backed zsh-fork integration tests.Deleting the old
shell-tool-mcpworkflow also deleted the only pipeline that rebuilt those patched zsh binaries. This keeps the package removal, while preserving a small release path that can be reused whenevercodex-rs/shell-escalation/patches/zsh-exec-wrapper.patchchanges.What changed
shell-tool-mcpworkspace package, its npm packaging/release jobs, the Bash test fixture, and the remaining Bash-specific compatibility wiring.github/workflows/shell-tool-mcp.ymland.github/workflows/shell-tool-mcp-ci.ymlworkflows now that their responsibilities have been replaced or removedcodex-rs/shell-escalation/patches/zsh-exec-wrapper.patchand updated thecodex-rs/shell-escalationdocs/code to describe the zsh-based flow directly.github/workflows/rust-release-zsh.ymlto build only the three zsh binaries thatcodex-rs/app-server/tests/suite/zshneeds today:aarch64-apple-darwinonmacos-15x86_64-unknown-linux-muslonubuntu-24.04aarch64-unknown-linux-muslonubuntu-24.04.github/scripts/build-zsh-release-artifact.sh, made that helper directly executable, and now invoke it directly from the workflow so the Linux and macOS jobs only keep the OS-specific setup in YAMLcodex-zsh-*.tar.gzassets intorust-release.ymland added.github/dotslash-zsh-config.jsonso releases also publish acodex-zshDotSlash filecodex-rs/app-server/tests/suite/zshfixture comments to explain that new releases come from the standalone zsh assets, while the checked-in fixture remains pinned to the latest historical release until a newer zsh artifact is publishedcodex-rs/shell-escalation: theExecParams::commandcomment now describes the shell-c/-lcstring more clearly, and the README now points at the samegit.code.sf.netzsh source URL that the workflow usesTesting
cargo test -p codex-shell-escalationjust argument-comment-lintbash -n .github/scripts/build-zsh-release-artifact.shcargo test -p codex-core; unrelated existing failures remain, but the touchedtools::runtimes::shell::unix_escalation::*coverage passed during that run