Add marketplace command by xli-oai · Pull Request #17087 · openai/codex

xli-oai · 2026-04-08T05:46:57Z

Added a new top-level codex marketplace add command for installing plugin marketplaces into Codex’s local marketplace cache.

This change adds source parsing for local directories, GitHub shorthand, and git URLs, supports optional --ref and git-only --sparse checkout paths, stages the source in a temp directory, validates the marketplace manifest, and installs it under $CODEX_HOME/marketplaces/<marketplace-name>

Included tests cover local install behavior in the CLI and marketplace discovery from installed roots in core. Scoped formatting and fix passes were run, and targeted CLI/core tests passed.

github-actions · 2026-04-08T05:47:09Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

xli-oai · 2026-04-08T05:50:02Z

I have read the CLA Document and I hereby sign the CLA

xli-oai · 2026-04-08T21:22:14Z

Design / storage summary for the current branch:

Filesystem layout

$CODEX_HOME/.tmp/plugins/ remains the existing OpenAI-curated marketplace checkout. This PR does not move or rename it.
$CODEX_HOME/.tmp/marketplaces/<marketplace-name>/ is where marketplaces added by codex marketplace add are materialized.
$CODEX_HOME/.tmp/marketplaces/.staging/ is temporary staging space used while cloning/copying before install.
$CODEX_HOME/plugins/cache/<marketplace>/<plugin>/<version>/ remains the existing plugin artifact/install cache. Marketplace add does not install plugin artifacts into this cache.

State

User-added marketplace metadata is stored in $CODEX_HOME/config.toml under [marketplaces.<marketplace-name>].
Each entry records last_updated, source_type, source, optional ref, and optional sparse_paths.
known_marketplaces.json is no longer written or read.
.codex-marketplace-source is no longer written or read.

Flow

codex marketplace add <source> accepts a local marketplace directory or Git source. It checks config.toml for an existing matching source, stages the source by copying/cloning when needed, validates the staged root as a Codex marketplace, rejects the reserved openai-curated marketplace name, installs under .tmp/marketplaces/<name>, and records metadata in config.toml.

Adding the same normalized source again is idempotent. Adding a different source with the same marketplace name is rejected instead of replacing the existing marketplace.

xl-openai · 2026-04-08T23:28:18Z

    }
 }

+pub fn marketplace_install_root(codex_home: &Path) -> PathBuf {


maybe have a marketplace.rs or something as this file becomes too big.

Addressed in 53deb35f0: I split installed marketplace root discovery out of core/src/plugins/manager.rs into core/src/plugins/installed_marketplaces.rs. manager.rs now only asks for configured marketplace roots; the new module owns the config-to-filesystem discovery helper and the installed marketplace directory constant. Earlier in 16813bd29, I also split the CLI clone/copy/replace helpers into marketplace_cmd/ops.rs.

xl-openai · 2026-04-08T23:32:23Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f9b23d58b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

xli-oai · 2026-04-09T04:57:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 972d3a5495

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

sayan-oai

thanks for cleaning up! one nit

xli-oai · 2026-04-10T18:20:04Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: add49f91b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

xli-oai · 2026-04-10T18:27:11Z

Updated design summary after the latest config-only changes:

State and metadata

User-added marketplace metadata is stored in $CODEX_HOME/config.toml under [marketplaces.<marketplace-name>].
Each entry records last_updated, source_type, source, optional ref, and optional sparse_paths.
known_marketplaces.json is no longer written or read.
.codex-marketplace-source is no longer written or read.

Filesystem layout

$CODEX_HOME/.tmp/plugins/ remains the existing OpenAI-curated marketplace checkout.
$CODEX_HOME/.tmp/marketplaces/<marketplace-name>/ stores marketplaces added by codex marketplace add.
$CODEX_HOME/.tmp/marketplaces/.staging/ is temporary staging space for copy/clone before install.
$CODEX_HOME/plugins/cache/<marketplace>/<plugin>/<version>/ remains the existing plugin artifact cache and is not changed by marketplace add.

Flow

codex marketplace add <source> parses a local directory or Git source, checks config.toml for an existing matching source, stages by copying/cloning when needed, validates the marketplace manifest, rejects the reserved openai-curated name, installs under .tmp/marketplaces/<name>, and writes the config metadata. Adding the same source again is idempotent; adding a different source with the same marketplace name is rejected.

xli-oai · 2026-04-10T18:54:47Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cdac5ef786

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-10T19:02:12Z

+
+    let source = expand_home(source);
+    let path = PathBuf::from(&source);
+    let path_exists = path.try_exists().with_context(|| {


Classify git URLs before try_exists to avoid Windows failures

parse_marketplace_source calls PathBuf::try_exists() on raw input before URL classification. On Windows, inputs like https://... or git@host:repo can raise invalid-name errors, causing an early "failed to access local marketplace source" failure instead of parsing as git sources. This breaks advertised URL-based installs on Windows.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-10T19:02:12Z

+fn is_ssh_git_url(source: &str) -> bool {
+    source.starts_with("git@") && source.contains(':')


Accept ssh:// URLs promised by marketplace source docs

The command docs say SOURCE supports SSH URLs, but is_ssh_git_url only recognizes scp-style git@...:.... A valid SSH URL like ssh://git@github.com/org/repo.git falls through and is rejected as an invalid source format, which mismatches the declared behavior.

Useful? React with 👍 / 👎.

xli-oai · 2026-04-10T19:21:13Z

@codex reivew

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 238f4b1214

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-10T19:27:18Z

+    if url.starts_with("https://github.com/") && !url.ends_with(".git") {
+        format!("{url}.git")
+    } else {


Trim trailing slash before appending .git

normalize_git_url blindly appends .git for any https://github.com/... URL without that suffix. If the user passes a common copied URL ending in / (e.g. https://github.com/org/repo/), this becomes .../repo/.git, which points to a different path and causes marketplace add clone failures. Strip a trailing slash before normalization.

Useful? React with 👍 / 👎.

Addressed in 674015acd: normalize_git_url now trims trailing slashes before appending .git, so https://github.com/org/repo/ normalizes to https://github.com/org/repo.git instead of https://github.com/org/repo/.git. I also added parser coverage for this trailing-slash GitHub URL shape.

xli-oai · 2026-04-10T19:58:05Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 674015acdf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-10T20:05:49Z

+    let Ok(config) = std::fs::read_to_string(&config_path) else {
+        return Ok(None);


Handle config read errors instead of treating as missing

installed_marketplace_root_for_source swallows every read_to_string error and returns Ok(None). Permission/I/O failures are misclassified as “no config”, so marketplace add can continue and later fail after mutating disk. Only NotFound should be ignored; other read errors should abort early.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-10T20:05:49Z

+    ops::replace_marketplace_root(&staged_root, &destination)
+        .with_context(|| format!("failed to install marketplace at {}", destination.display()))?;
+    record_added_marketplace(&codex_home, &marketplace_name, &install_metadata)?;


Persist marketplace config before finalizing install move

run_add moves the staged directory into the install root before updating config.toml. If record_added_marketplace fails (e.g., invalid or unwritable config), the command errors but leaves the marketplace installed. Subsequent retries hit the existing destination and fail as a “different source,” requiring manual cleanup.

Useful? React with 👍 / 👎.

…-add-command

xli-oai · 2026-04-11T02:18:45Z

@codex review

xli-oai · 2026-04-11T02:54:31Z

@codex review

github-actions bot added a commit that referenced this pull request Apr 8, 2026

@xli-oai has signed the CLA in #17087

d204192

xl-openai reviewed Apr 8, 2026

View reviewed changes

Comment thread codex-rs/core/src/plugins/manager.rs Outdated

xl-openai reviewed Apr 8, 2026

View reviewed changes

Comment thread codex-rs/cli/src/marketplace_cmd.rs Outdated

xl-openai reviewed Apr 8, 2026

View reviewed changes

Comment thread codex-rs/core/src/plugins/manager.rs Outdated

xli-oai marked this pull request as ready for review April 8, 2026 21:32

xli-oai force-pushed the xli-codex/marketplace-add-command branch 6 times, most recently from faaff79 to f4909a7 Compare April 8, 2026 23:24

xl-openai reviewed Apr 8, 2026

View reviewed changes

Add marketplace add command support

f9b23d5

xli-oai force-pushed the xli-codex/marketplace-add-command branch from f4909a7 to f9b23d5 Compare April 8, 2026 23:32

chatgpt-codex-connector bot reviewed Apr 8, 2026

View reviewed changes

Comment thread codex-rs/core/src/plugins/manager.rs Outdated

Comment thread codex-rs/cli/src/marketplace_cmd.rs Outdated

github-actions bot mentioned this pull request Apr 9, 2026

📊 AI CLI 工具社区动态日报 2026-04-09 gsscsd/big_model_radar#157

Open

xli-oai requested a review from sayan-oai April 9, 2026 03:03

sayan-oai reviewed Apr 9, 2026

View reviewed changes

Comment thread codex-rs/core/src/plugins/manager.rs Outdated

sayan-oai reviewed Apr 9, 2026

View reviewed changes

Comment thread codex-rs/cli/src/marketplace_cmd.rs Outdated

Comment thread codex-rs/cli/src/marketplace_cmd.rs Outdated

xli-oai added 4 commits April 8, 2026 21:41

Address marketplace add review feedback

adbc32b

Fix marketplace add sparse argument parsing

23f845b

Test marketplace add sparse CLI parsing

bd32fb4

Reject invalid marketplace names on add

972d3a5

chatgpt-codex-connector bot reviewed Apr 9, 2026

View reviewed changes

Comment thread codex-rs/cli/src/marketplace_cmd.rs

Comment thread codex-rs/cli/src/marketplace_cmd/metadata.rs Outdated

xl-openai approved these changes Apr 9, 2026

View reviewed changes

sayan-oai approved these changes Apr 9, 2026

View reviewed changes

Comment thread codex-rs/cli/src/marketplace_cmd.rs Outdated

xli-oai force-pushed the xli-codex/marketplace-add-command branch from e8fa02e to 972d3a5 Compare April 9, 2026 22:14

Store marketplace metadata in config

add49f9

chatgpt-codex-connector bot reviewed Apr 10, 2026

View reviewed changes

Comment thread codex-rs/cli/src/marketplace_cmd.rs Outdated

Comment thread codex-rs/cli/src/marketplace_cmd.rs Outdated

Split marketplace CLI operations

16813bd

xli-oai added 2 commits April 10, 2026 11:34

Split installed marketplace discovery

53deb35

Tighten marketplace source parsing

cdac5ef

chatgpt-codex-connector bot reviewed Apr 10, 2026

View reviewed changes

Fix marketplace Git URL parsing

238f4b1

chatgpt-codex-connector bot reviewed Apr 10, 2026

View reviewed changes

Normalize marketplace GitHub URLs with trailing slash

674015a

chatgpt-codex-connector bot reviewed Apr 10, 2026

View reviewed changes

xli-oai added 7 commits April 10, 2026 13:20

Disable execpolicy legacy Bazel build script

7021f7c

Fix marketplace add consistency

640a1ae

Restrict marketplace add to remote git sources

df213f7

Remove redundant execpolicy legacy build script

497f3ad

Merge remote-tracking branch 'origin/main' into xli-codex/marketplace…

1dadae7

…-add-command

Fix marketplace argument comment lint

09b9ea3

Save current marketplace-add branch state

d44bbf3

xli-oai merged commit f9a8d18 into main Apr 11, 2026
21 of 22 checks passed

xli-oai deleted the xli-codex/marketplace-add-command branch April 11, 2026 02:18

github-actions bot locked and limited conversation to collaborators Apr 11, 2026

xli-oai added the oai PRs contributed by OpenAI employees label Apr 13, 2026

		fn is_ssh_git_url(source: &str) -> bool {
		source.starts_with("git@") && source.contains(':')

		let Ok(config) = std::fs::read_to_string(&config_path) else {
		return Ok(None);

Conversation

xli-oai commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xli-oai commented Apr 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xli-oai commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xl-openai Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

sayan-oai Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

xli-oai Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xl-openai commented Apr 8, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xli-oai commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

sayan-oai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xli-oai commented Apr 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

xli-oai commented Apr 10, 2026

Uh oh!

xli-oai commented Apr 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

xli-oai commented Apr 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

xli-oai Apr 10, 2026

xli-oai commented Apr 8, 2026 •

edited

Loading

github-actions bot commented Apr 8, 2026 •

edited

Loading

xli-oai commented Apr 8, 2026 •

edited

Loading

xli-oai Apr 10, 2026 •

edited

Loading