Skip to content

Launch image generation by default #17153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aibrahim-oai merged 4 commits into from
Apr 16, 2026
Merged

Launch image generation by default #17153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e65c3e1
Launch image generation by default
won-openai Apr 8, 2026
0aef08e
Update image generation default tool expectations
won-openai Apr 8, 2026
03c54c1
Merge branch 'main' into launch_image_gen_cli
won-openai Apr 16, 2026
691b6bd
Fix image generation feature test delimiter
won-openai Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions codex-rs/core/src/tools/spec_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,7 @@ async fn test_build_specs_gpt5_codex_default() {
"request_user_input",
"apply_patch",
"web_search",
"image_generation",
"view_image",
"spawn_agent",
"send_input",
Expand All @@ -441,6 +442,7 @@ async fn test_build_specs_gpt51_codex_default() {
"request_user_input",
"apply_patch",
"web_search",
"image_generation",
"view_image",
"spawn_agent",
"send_input",
Expand All @@ -467,6 +469,7 @@ async fn test_build_specs_gpt5_codex_unified_exec_web_search() {
"request_user_input",
"apply_patch",
"web_search",
"image_generation",
"view_image",
"spawn_agent",
"send_input",
Expand All @@ -493,6 +496,7 @@ async fn test_build_specs_gpt51_codex_unified_exec_web_search() {
"request_user_input",
"apply_patch",
"web_search",
"image_generation",
"view_image",
"spawn_agent",
"send_input",
Expand All @@ -517,6 +521,7 @@ async fn test_gpt_5_1_codex_max_defaults() {
"request_user_input",
"apply_patch",
"web_search",
"image_generation",
"view_image",
"spawn_agent",
"send_input",
Expand All @@ -541,6 +546,7 @@ async fn test_codex_5_1_mini_defaults() {
"request_user_input",
"apply_patch",
"web_search",
"image_generation",
"view_image",
"spawn_agent",
"send_input",
Expand All @@ -564,6 +570,7 @@ async fn test_gpt_5_defaults() {
"update_plan",
"request_user_input",
"web_search",
"image_generation",
"view_image",
"spawn_agent",
"send_input",
Expand All @@ -588,6 +595,7 @@ async fn test_gpt_5_1_defaults() {
"request_user_input",
"apply_patch",
"web_search",
"image_generation",
"view_image",
"spawn_agent",
"send_input",
Expand All @@ -614,6 +622,7 @@ async fn test_gpt_5_1_codex_max_unified_exec_web_search() {
"request_user_input",
"apply_patch",
"web_search",
"image_generation",
"view_image",
"spawn_agent",
"send_input",
Expand Down
4 changes: 2 additions & 2 deletions codex-rs/features/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,8 +812,8 @@ pub const FEATURES: &[FeatureSpec] = &[
FeatureSpec {
id: Feature::ImageGeneration,
key: "image_generation",
stage: Stage::UnderDevelopment,
default_enabled: false,
stage: Stage::Stable,
default_enabled: true,
},
FeatureSpec {
id: Feature::SkillMcpDependencyInstall,
Expand Down
12 changes: 6 additions & 6 deletions codex-rs/features/src/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,12 @@ fn use_linux_sandbox_bwrap_is_a_removed_feature_key() {
);
}

#[test]
fn image_generation_is_stable_and_enabled_by_default() {
assert_eq!(Feature::ImageGeneration.stage(), Stage::Stable);
assert_eq!(Feature::ImageGeneration.default_enabled(), true);
}

#[test]
fn image_detail_original_is_a_removed_feature_key() {
Comment thread
won-openai marked this conversation as resolved.
assert_eq!(
Expand All @@ -168,12 +174,6 @@ fn image_detail_original_is_a_removed_feature_key() {
);
}

#[test]
fn image_generation_is_under_development() {
assert_eq!(Feature::ImageGeneration.stage(), Stage::UnderDevelopment);
assert_eq!(Feature::ImageGeneration.default_enabled(), false);
}

#[test]
fn tool_call_mcp_elicitation_is_stable_and_enabled_by_default() {
assert_eq!(Feature::ToolCallMcpElicitation.stage(), Stage::Stable);
Expand Down
1 change: 1 addition & 0 deletions codex-rs/tools/src/tool_registry_plan_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ fn test_full_toolset_specs_for_gpt5_codex_unified_exec_web_search() {
search_context_size: None,
search_content_types: None,
},
create_image_generation_tool("png"),
create_view_image_tool(ViewImageToolOptions {
can_request_original_image_detail: config.can_request_original_image_detail,
}),
Expand Down
Loading