fix(linux-sandbox): recreate symlink aliases for writable roots#17295
Open
viyatb-oai wants to merge 3 commits intomainfrom
Open
fix(linux-sandbox): recreate symlink aliases for writable roots#17295viyatb-oai wants to merge 3 commits intomainfrom
viyatb-oai wants to merge 3 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc29af481e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
viyatb-oai
force-pushed
the
codex/viyatb/recreate-bwrap-symlink-aliases
branch
from
cc29af4 to
e8aefa2
Compare
Co-authored-by: Codex noreply@openai.com
viyatb-oai
force-pushed
the
codex/viyatb/recreate-bwrap-symlink-aliases
branch
from
e8aefa2 to
d50d061
Compare
Co-authored-by: Codex noreply@openai.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #15981 for the remaining logical-symlink compatibility gap.
Absolute logical symlink paths are still not universally recreated inside restricted bwrap; the fix makes relative execution and writable-root binding work safely. If #15157 requires every logical absolute path to remain addressable inside the sandbox, that is a larger alias-recreation problem.
This PR starts that larger alias-recreation work for the Linux bwrap path by recreating the first logical symlink component for symlinked writable roots when the alias is not already visible through a logical read mount. That lets absolute logical paths such as a symlinked workspace root resolve inside restricted bwrap while still binding writes to the real target from #15981.
Validation:
Related: #15157