[codex] Refactor marketplace add into shared core flow#17717
Merged
Conversation
xl-openai
approved these changes
Apr 14, 2026
xli-oai
force-pushed
the
xli-codex/marketplace-add-shared-impl
branch
from
cb2de60 to
1352f5c
Compare
## Summary Add a new app-server `marketplace/add` RPC on top of the shared marketplace-add implementation. This change: - adds `MarketplaceAddParams` / `MarketplaceAddResponse` to the app-server protocol - wires the new request through `codex_message_processor` - reuses the shared core marketplace-add flow from the lower refactor PR - updates generated schema files and adds focused protocol and app-server coverage ## Why The TUI can already browse, inspect, install, and uninstall plugins, but it did not have a backend API for adding a marketplace source. With the shared CLI/core refactor below this PR, the API now reuses the same underlying implementation instead of carrying its own duplicate flow. ## Validation - `cargo test -p codex-app-server-protocol marketplace_add` - `cargo test -p codex-app-server marketplace_add`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
codex marketplace addonto a shared core implementation so the CLI and app-server path can use one source of truth.This change:
codex-coreWhy
The new
marketplace/addRPC should reuse the same underlying marketplace-add flow as the CLI. This refactor lands that consolidation first so the follow-up app-server PR can be mostly protocol and handler wiring.Validation
cargo test -p codex-core marketplace_addcargo test -p codex-cli marketplace_cmdjust fix -p codex-corejust fix -p codex-clijust fmt