Skip to content

feat(config): support managed deny-read requirements #17740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bolinfest merged 2 commits into from
Apr 17, 2026
Merged

feat(config): support managed deny-read requirements #17740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1090c1
feat(config): support managed deny-read requirements
viyatb-oai Apr 16, 2026
e665898
fix(config): use glob pattern filesystem path variant
viyatb-oai Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions codex-rs/app-server/src/config_api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,6 +605,7 @@ mod tests {
}),
allow_local_binding: Some(true),
}),
permissions: None,
};

let mapped = map_requirements_toml_to_api(requirements);
Expand Down Expand Up @@ -698,6 +699,7 @@ mod tests {
}),
allow_local_binding: None,
}),
permissions: None,
};

let mapped = map_requirements_toml_to_api(requirements);
Expand Down Expand Up @@ -739,6 +741,7 @@ mod tests {
rules: None,
enforce_residency: None,
network: None,
permissions: None,
};

let mapped = map_requirements_toml_to_api(requirements);
Expand Down
16 changes: 16 additions & 0 deletions codex-rs/cloud-requirements/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,6 +1172,7 @@ mod tests {
rules: None,
enforce_residency: None,
network: None,
permissions: None,
}))
);
}
Expand Down Expand Up @@ -1201,6 +1202,7 @@ mod tests {
rules: None,
enforce_residency: None,
network: None,
permissions: None,
}))
);
}
Expand Down Expand Up @@ -1230,6 +1232,7 @@ mod tests {
rules: None,
enforce_residency: None,
network: None,
permissions: None,
}))
);
}
Expand Down Expand Up @@ -1276,6 +1279,7 @@ mod tests {
rules: None,
enforce_residency: None,
network: None,
permissions: None,
})
);
}
Expand Down Expand Up @@ -1358,6 +1362,7 @@ enabled = false
rules: None,
enforce_residency: None,
network: None,
permissions: None,
}))
);
assert_eq!(fetcher.request_count.load(Ordering::SeqCst), 2);
Expand Down Expand Up @@ -1430,6 +1435,7 @@ enabled = false
rules: None,
enforce_residency: None,
network: None,
permissions: None,
}))
);
assert_eq!(fetcher.request_count.load(Ordering::SeqCst), 2);
Expand Down Expand Up @@ -1500,6 +1506,7 @@ enabled = false
rules: None,
enforce_residency: None,
network: None,
permissions: None,
}))
);

Expand Down Expand Up @@ -1697,6 +1704,7 @@ enabled = false
rules: None,
enforce_residency: None,
network: None,
permissions: None,
}))
);
assert_eq!(fetcher.request_count.load(Ordering::SeqCst), 0);
Expand Down Expand Up @@ -1732,6 +1740,7 @@ enabled = false
rules: None,
enforce_residency: None,
network: None,
permissions: None,
}))
);

Expand Down Expand Up @@ -1787,6 +1796,7 @@ enabled = false
rules: None,
enforce_residency: None,
network: None,
permissions: None,
}))
);
assert_eq!(fetcher.request_count.load(Ordering::SeqCst), 1);
Expand Down Expand Up @@ -1837,6 +1847,7 @@ enabled = false
rules: None,
enforce_residency: None,
network: None,
permissions: None,
}))
);
assert_eq!(fetcher.request_count.load(Ordering::SeqCst), 1);
Expand Down Expand Up @@ -1891,6 +1902,7 @@ enabled = false
rules: None,
enforce_residency: None,
network: None,
permissions: None,
}))
);
assert_eq!(fetcher.request_count.load(Ordering::SeqCst), 1);
Expand Down Expand Up @@ -1946,6 +1958,7 @@ enabled = false
rules: None,
enforce_residency: None,
network: None,
permissions: None,
}))
);
assert_eq!(fetcher.request_count.load(Ordering::SeqCst), 1);
Expand Down Expand Up @@ -2001,6 +2014,7 @@ enabled = false
rules: None,
enforce_residency: None,
network: None,
permissions: None,
})
);
let payload_bytes = cache_payload_bytes(&cache_file.signed_payload).expect("payload bytes");
Expand Down Expand Up @@ -2089,6 +2103,7 @@ enabled = false
rules: None,
enforce_residency: None,
network: None,
permissions: None,
}))
);

Expand Down Expand Up @@ -2116,6 +2131,7 @@ enabled = false
rules: None,
enforce_residency: None,
network: None,
permissions: None,
})
);
}
Expand Down
Loading
Loading