Skip to content

/plugins: Add inline enablement toggles#18395

Merged
canvrno-oai merged 2 commits intomainfrom
canvrno/tui_plugins_menu_v2_enable_disable
Apr 18, 2026
Merged

/plugins: Add inline enablement toggles#18395
canvrno-oai merged 2 commits intomainfrom
canvrno/tui_plugins_menu_v2_enable_disable

Conversation

@canvrno-oai
Copy link
Copy Markdown
Contributor

This PR adds inline enable/disable controls to the new /plugins browse menu. Installed plugins can now be toggled directly from the list with keyboard interaction, and the associated config-write plumbing is included so the UI and persisted plugin state stay in sync. This also includes the queued-write handling needed to avoid stale toggle completions overwriting newer intent.

  • Add toggleable plugin rows for installed plugins in /plugins
  • Support Space to enable or disable without leaving the list
  • Persist plugin enablement through the existing app/config write path
  • Preserve the current selection while the list refreshes after a toggle
  • Add tests and snapshot updates for toggling behavior

@canvrno-oai
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f020825be5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/app.rs
@canvrno-oai canvrno-oai marked this pull request as ready for review April 17, 2026 21:53
@fcoury-oai fcoury-oai self-assigned this Apr 17, 2026
Copy link
Copy Markdown
Contributor

@fcoury-oai fcoury-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it looks good. One minor detail is pressing Esc while on a plugin detail page exits to the composer instead of falling back to the previous menu, but this can be adjusted on a follow up PR.

@canvrno-oai canvrno-oai force-pushed the canvrno/tui_plugins_menu_v2_enable_disable branch from f020825 to 8b97290 Compare April 18, 2026 00:19
@canvrno-oai canvrno-oai merged commit 06f8ec5 into main Apr 18, 2026
25 checks passed
@canvrno-oai canvrno-oai deleted the canvrno/tui_plugins_menu_v2_enable_disable branch April 18, 2026 00:33
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants