Add turn-scoped environment selections by starr-openai · Pull Request #18416 · openai/codex

starr-openai · 2026-04-17T23:29:23Z

Summary

add experimental turn/start.environments params for per-turn environment id + cwd selections
pass selections through core protocol ops and resolve them with EnvironmentManager before TurnContext creation
treat omitted selections as default behavior, empty selections as no environment, and non-empty selections as first environment/cwd as the turn primary

Testing

ran just fmt
ran just write-app-server-schema
not run: unit tests for this stacked PR

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 82608fb065

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

pakrym-oai · 2026-04-21T01:08:08Z

    access: proc_macro2::TokenStream,
    ty: &Type,
 ) -> proc_macro2::TokenStream {
-    if let Some(inner) = option_inner(ty) {


ooc why did this have to change?

weird - maybe a rebase conflict or other change i had.- let me remove

ah this was for the experimental config stuff. removing that, I don't think we really need to gate it

pakrym-oai · 2026-04-21T01:14:34Z

 }

+#[tokio::test]
+async fn turn_environment_selection_sets_primary_environment() {


up to you but I don't find these unit tests that assert internal implementation details particularly useful long-term.

pakrym-oai · 2026-04-21T01:14:59Z

+#[tokio::test]
+async fn turn_environment_selection_sets_primary_environment() {
+    let (session, _turn_context, _rx) = make_session_and_context_with_rx().await;
+    let selected_cwd =


Are we turning AbsolutePath into pathbuf just to parse it back?

pakrym-oai · 2026-04-21T01:16:17Z

        models_manager: &ModelsManager,
        network: Option<NetworkProxy>,
        environment: Option<Arc<Environment>>,
+        environments: Option<Vec<TurnEnvironment>>,


should this be optional?

Feels like it should be materialized either into an empty list or non-empty list but never None.

we're still using the Option state to determine if env is enabled or not for tool access. will make this explicit in the later pr once this is attached to persistent thread state

pakrym-oai · 2026-04-21T01:17:04Z

+                .services
+                .environment_manager
+                .get_environment(&environment_selection.environment_id)
+                .ok_or_else(|| codex_config::ConstraintError::InvalidValue {


is this the correct error type?

I think ConstraintError::InvalidValue is for requirements.toml

pakrym-oai · 2026-04-21T01:20:44Z

            sub_id,
            session_configuration,
            /*final_output_json_schema*/ None,
+            /*turn_environments*/ None,


Is this correct? WebSocket prewarm uses this.
We establish a websocket connection and send an initial empty responses api request to warm up inference. That request includes tools. If we pass None environemnt here the first request will be sent without tools even for local environment which will break prewarming.

We might want to add environments onto thread/start to help the prewarm send the right request.

pakrym-oai · 2026-04-21T01:23:27Z

                &per_turn_config.to_models_manager_config(),
            )
            .await;
+        let environment = match turn_environments.as_ref() {


nit: maybe grab turn_environments.first() first and then set both environment and cwd

pakrym-oai · 2026-04-21T01:24:54Z

+        per_turn_config.cwd = cwd.clone();
        let plugin_outcome = self


nit: can we pass cwd into build_per_turn_config and have it build the correct value from the getgo?

pakrym-oai

Should we make environments non-optional?

Co-authored-by: Codex <noreply@openai.com>

Use the generated executable path directly in the Unix script execution test so the assertion covers shebang execution without depending on PATH lookup behavior in the test runner. Co-authored-by: Codex <noreply@openai.com>

starr-openai force-pushed the turn-environments-20260417 branch 4 times, most recently from 7986b94 to 8fa3ca6 Compare April 18, 2026 01:41

starr-openai force-pushed the env-manager-map-20260417 branch from 127619c to 74bfde4 Compare April 18, 2026 01:48

starr-openai force-pushed the turn-environments-20260417 branch from 8fa3ca6 to 890e4cb Compare April 18, 2026 01:49

starr-openai force-pushed the env-manager-map-20260417 branch from 74bfde4 to b1dcb7a Compare April 18, 2026 01:56

starr-openai force-pushed the turn-environments-20260417 branch 2 times, most recently from 1578eb9 to 88861aa Compare April 18, 2026 02:20

starr-openai force-pushed the env-manager-map-20260417 branch from b1dcb7a to bf60062 Compare April 20, 2026 18:52

starr-openai force-pushed the turn-environments-20260417 branch from 88861aa to 0fcde7d Compare April 20, 2026 18:53

starr-openai force-pushed the env-manager-map-20260417 branch from bf60062 to dd5a687 Compare April 20, 2026 18:54

starr-openai force-pushed the turn-environments-20260417 branch 2 times, most recently from d28fd65 to 7fdd192 Compare April 20, 2026 18:56

starr-openai force-pushed the env-manager-map-20260417 branch from dd5a687 to ec3596e Compare April 20, 2026 18:58

starr-openai force-pushed the turn-environments-20260417 branch from 7fdd192 to fa62276 Compare April 20, 2026 18:58

starr-openai force-pushed the env-manager-map-20260417 branch from ec3596e to 8f1d61b Compare April 20, 2026 19:04

starr-openai force-pushed the turn-environments-20260417 branch from fa62276 to 410171c Compare April 20, 2026 19:04

starr-openai force-pushed the env-manager-map-20260417 branch from 8f1d61b to 70d3a74 Compare April 20, 2026 19:32

starr-openai force-pushed the turn-environments-20260417 branch 3 times, most recently from af9a36d to 21807b7 Compare April 20, 2026 20:01

starr-openai marked this pull request as ready for review April 20, 2026 21:26

starr-openai requested a review from a team as a code owner April 20, 2026 21:26

chatgpt-codex-connector Bot reviewed Apr 20, 2026

View reviewed changes

Comment thread codex-rs/core/src/session/turn_context.rs

pakrym-oai reviewed Apr 21, 2026

View reviewed changes

github-actions Bot mentioned this pull request Apr 21, 2026

📊 AI CLI 工具社区动态日报 2026-04-21 gsscsd/big_model_radar#220

Open

pakrym-oai reviewed Apr 21, 2026

View reviewed changes

pakrym-oai approved these changes Apr 21, 2026

View reviewed changes

starr-openai force-pushed the env-manager-map-20260417 branch from 3b5e90b to 154be3f Compare April 21, 2026 17:36

starr-openai force-pushed the turn-environments-20260417 branch 5 times, most recently from c2fbdee to 675777c Compare April 21, 2026 20:13

starr-openai force-pushed the env-manager-map-20260417 branch 2 times, most recently from 981cdd6 to 3ec48a2 Compare April 21, 2026 21:50

Base automatically changed from env-manager-map-20260417 to main April 21, 2026 22:29

starr-openai force-pushed the turn-environments-20260417 branch from b49f5c0 to 3fdd893 Compare April 21, 2026 23:40

starr-openai and others added 6 commits April 21, 2026 16:41

Add turn-scoped environment selections

4ff6f2c

Co-authored-by: Codex <noreply@openai.com>

codex: document turn environments API

b42bada

Co-authored-by: Codex <noreply@openai.com>

codex: gate empty experimental fields

192374e

Co-authored-by: Codex <noreply@openai.com>

codex: remove dead experimental helper

965ee77

Co-authored-by: Codex <noreply@openai.com>

codex: remove verbose environment docs

053d762

Co-authored-by: Codex <noreply@openai.com>

codex: tighten turn environment errors

8dac6ca

Co-authored-by: Codex <noreply@openai.com>

starr-openai force-pushed the turn-environments-20260417 branch from 3fdd893 to 8dac6ca Compare April 21, 2026 23:41

codex: fix musl rmcp-client test

734e853

Use the generated executable path directly in the Unix script execution test so the assertion covers shebang execution without depending on PATH lookup behavior in the test runner. Co-authored-by: Codex <noreply@openai.com>

starr-openai force-pushed the turn-environments-20260417 branch from 15b61dc to 734e853 Compare April 22, 2026 00:12

starr-openai merged commit 1d4cc49 into main Apr 22, 2026
25 checks passed

starr-openai deleted the turn-environments-20260417 branch April 22, 2026 00:48

github-actions Bot locked and limited conversation to collaborators Apr 22, 2026

Conversation

starr-openai commented Apr 17, 2026

Summary

Testing

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pakrym-oai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants