Queue slash and shell prompts in the TUI#18542
Merged
etraut-openai merged 3 commits intomainfrom Apr 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 550ffdfff5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fcoury-oai
approved these changes
Apr 19, 2026
Contributor
fcoury-oai
left a comment
There was a problem hiding this comment.
Also tested and worked perfectly.
Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Users have asked to queue follow-up slash commands while a task is running, including in #14081, #14588, #14286, and #13779. The previous TUI behavior validated slash commands immediately, so commands that are only meaningful once the current turn is idle could not be queued consistently.
The queue should preserve what the user typed and defer command parsing until the item is actually dispatched. This also gives
/fast,/review ...,/rename ...,/model,/permissions, and similar slash workflows the same FIFO behavior as plain queued prompts.What Changed
Tabqueueing to accept slash-led prompts without validating them up front, then parse and dispatch them when dequeued.!shell-command queueing forTabwhile a task is running, while preserving existingEnterbehavior for immediate shell execution./mo<Tab>completes to/modelinstead of queueing the prefix.Verification
I did a bunch of manual validation (and found and fixed a few bugs along the way).