[rollout_trace] Record core session rollout traces#18877
Merged
cassirer-openai merged 6 commits intomainfrom Apr 22, 2026
Merged
[rollout_trace] Record core session rollout traces#18877cassirer-openai merged 6 commits intomainfrom
cassirer-openai merged 6 commits intomainfrom
Conversation
This was referenced Apr 21, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
codex/codex-rs/core/src/session/handlers.rs
Lines 969 to 973 in 3844251
Record thread shutdown in rollout trace
Session shutdown sends ShutdownComplete but never calls rollout_trace.record_thread_ended(...). As a result, traces never emit ThreadEnded/RolloutEnded, leaving rollout status stuck in running and dropping the session lifecycle boundary this change is meant to capture.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cassirer-openai
force-pushed
the
codex/rollout-trace-core-recorder
branch
from
3844251 to
582bf74
Compare
cassirer-openai
force-pushed
the
codex/rollout-trace-crate
branch
from
f1f33a0 to
098ccc9
Compare
Contributor
Author
|
[codex] The review note about emitting |
cassirer-openai
force-pushed
the
codex/rollout-trace-crate
branch
from
098ccc9 to
15310f1
Compare
jif-oai
reviewed
Apr 21, 2026
cassirer-openai
added a commit
that referenced
this pull request
Apr 21, 2026
## Summary Adds the standalone `codex-rollout-trace` crate, which defines the raw trace event format, replay/reduction model, writer, and reducer logic for reconstructing model-visible conversation/runtime state from recorded rollout data. The crate-level design is documented in [`codex-rs/rollout-trace/README.md`](https://github.com/openai/codex/blob/codex/rollout-trace-crate/codex-rs/rollout-trace/README.md). ## Stack This is PR 1/5 in the rollout trace stack. - [#18876](#18876): Add rollout trace crate - [#18877](#18877): Record core session rollout traces - [#18878](#18878): Trace tool and code-mode boundaries - [#18879](#18879): Trace sessions and multi-agent edges - [#18880](#18880): Add debug trace reduction command ## Review Notes This PR intentionally does not wire tracing into live Codex execution. It establishes the data model and reducer contract first, with crate-local tests covering conversation reconstruction, compaction boundaries, tool/session edges, and code-cell lifecycle reduction. Later PRs emit into this model. The README is the best entry point for reviewing the intended trace format and reduction semantics before diving into the reducer modules.
cassirer-openai
force-pushed
the
codex/rollout-trace-core-recorder
branch
from
582bf74 to
899bb99
Compare
jif-oai
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires rollout trace recording into
codex-coresession and turn execution. This records the core model request/response, compaction, and session lifecycle boundaries needed for replay without yet tracing every nested runtime/tool boundary.Stack
This is PR 2/5 in the rollout trace stack.
Review Notes
This layer is the first live integration point. The important review question is whether trace recording is isolated from normal session behavior: trace failures should not become user-visible execution failures, and recording should preserve the existing turn/session lifecycle semantics.
The PR depends on the reducer/data model from the first stack entry and only introduces the core recorder surface that later PRs use for richer runtime and relationship events.