fix: wait_agent timeout for queued mailbox mail#18968
Merged
Conversation
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
wait_agentcan be called while mailbox mail is already pending. The previous implementation subscribed for future mailbox sequence changes and then waited for the next notification. If the mail was queued before that wait started, no new notification arrived, so the tool could sit untiltimeout_mseven though mail was ready to deliver.What Changed
Session::has_pending_mailbox_items()for checking pending mailbox mail through the session API.multi_agents_v2::waitto return immediately when pending mailbox mail already exists before sleeping on a new mailbox sequence update.multi_agents_tests.rsso already queued mailbox mail must wakewait_agentpromptly.Relevant code:
wait_agentpending-mail checkSession::has_pending_mailbox_itemsmulti_agent_v2_wait_agent_returns_for_already_queued_mailVerification
cargo test -p codex-core multi_agent_v2_wait_agent_returns_for_already_queued_mail