exec-server: expose fs helper alias roots#19029
Closed
starr-openai wants to merge 1 commit intomainfrom
Closed
Conversation
Allow the sandboxed filesystem helper to read both the real Codex binary parent and the codex-linux-sandbox arg0 alias parent. The Docker remote-env sandbox tests also pass an in-container cwd so the remote exec-server does not try to spawn helpers from a host checkout path. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex-linux-sandboxarg0 alias parentComparison with #19016
This is a smaller alternate to #19016. Both patches address the same two failure modes: the fs helper sandbox needs the arg0 alias parent, and the Docker remote-env tests must not send a host checkout cwd to the remote exec-server.
#19016 is broader: it moves cwd-dependency detection into the exec-server filesystem module, strips unused cwd values in the remote filesystem client for all remote fs calls, and adds transport-level unit coverage. This PR keeps the cwd fix local to the Docker remote-env tests, so it is narrower but less general. If the goal is product runtime hardening, #19016 looks more complete; this branch is the minimal repro/CI fix.
Verification
just fmtcargo test -p codex-core --test all suite::remote_env::remote_test_env_sandboxed_read_allows_readable_root -- --exact --nocaptureon Applied devbox Docker remote-env: passedcargo test -p codex-core --test all remote_test_env -- --nocaptureon Applied devbox Docker remote-env: 5 passed