Skip to content

Fix relative stdio MCP cwd fallback#19031

Merged
mzeng-openai merged 2 commits intomainfrom
dev/mzeng/fix-relative-stdio-cwd
Apr 23, 2026
Merged

Fix relative stdio MCP cwd fallback#19031
mzeng-openai merged 2 commits intomainfrom
dev/mzeng/fix-relative-stdio-cwd

Conversation

@mzeng-openai
Copy link
Copy Markdown
Collaborator

Summary

  • Pass the runtime fallback cwd into local stdio MCP launchers when server config omits cwd
  • Resolve relative stdio commands against that fallback cwd so Electron matches CLI behavior
  • Add a regression test for local stdio launch with a relative command and no configured cwd

Testing

  • just fmt
  • cargo test -p codex-rmcp-client
  • cargo test -p codex-core --test all local_stdio_server_uses_runtime_fallback_cwd_when_config_omits_cwd
  • just fix -p codex-rmcp-client
  • just fix -p codex-mcp
  • just fix -p codex-core

…ative-stdio-cwd

# Conflicts:
#	codex-rs/app-server/src/codex_message_processor.rs
@mzeng-openai mzeng-openai marked this pull request as ready for review April 22, 2026 23:21
@mzeng-openai mzeng-openai requested a review from a team as a code owner April 22, 2026 23:21
@mzeng-openai mzeng-openai merged commit 8f0a92c into main Apr 23, 2026
25 checks passed
@mzeng-openai mzeng-openai deleted the dev/mzeng/fix-relative-stdio-cwd branch April 23, 2026 00:52
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants