Conversation
dylan-hurd-oai
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set
RUST_MIN_STACK=8388608for Rust test entry points so libtest-spawned test threads get an 8 MiB stack.The Windows BuildBuddy failure on #18893 showed
//codex-rs/tui:tui-unit-testsexiting with a stack overflow in a#[tokio::test]even though later test binaries in the shard printed successful summaries. Default#[tokio::test]uses a current-thread Tokio runtime, which means the async test body is driven on libtest's std-spawned test thread. Increasing the test thread stack addresses that failure mode directly.To date, we have been fixing these stack-pressure problems with localized future-size reductions, such as #13429, and by adding
Box::pin()in specific async wrapper chains. This gives us a baseline test-runner stack size instead of continuing to patch individual tests only after CI finds another large async future.What changed
common --test_env=RUST_MIN_STACK=8388608in.bazelrcso Bazel test actions receive the env var through Bazel's cache-keyed test environment path.RUST_MIN_STACKvalue for Cargo/nextest CI entry points andjust test.Testing
just --list.github/workflows/rust-ci.ymland.github/workflows/rust-ci-full.ymlwith Ruby's YAML loaderbazel aqueryTestRunneraction keys before/after explicit--test_env=RUST_MIN_STACK=...and after moving the Bazel env to.bazelrcbazel test //codex-rs/tui:tui-unit-tests --test_output=errors