Persist target default reasoning on model upgrade#19085
Merged
shijie-oai merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
shijie-oai
commented
Apr 23, 2026
dylan-hurd-oai
approved these changes
Apr 23, 2026
225addc to
dc14777
Compare
dc14777 to
031608e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When the TUI upgrade flow moves a user to a newer model, the accepted migration should also persist the target model's default reasoning effort. That keeps the upgraded model and reasoning setting aligned instead of carrying forward a stale previously saved effort from the old model.
What changed
default_reasoning_effort.reasoning_effort_mappingexplicitly unused because mappings are no longer consulted on accepted migrations.mainalso updates a TUI thread-session test helper for the latestpermission_profilefield andApprovalsReviewer::AutoReviewrename so CI compiles on the new base.Verification
cargo test -p codex-tui model_catalogcargo test -p codex-tui permission_settings_sync_updates_active_snapshot_without_rewriting_side_thread