Reject agents.max_threads with multi_agent_v2#19129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
multi_agent_v2uses the v2 agent lifecycle, so accepting the legacyagents.max_threadslimit alongside it creates conflicting configuration semantics. Config load should fail early with a clear error instead of allowing both knobs to be set.What Changed
multi_agent_v2feature is enabled andagents.max_threadsis explicitly set.InvalidInputerror:agents.max_threads cannot be set when multi_agent_v2 is enabled.Verification
cargo test -p codex-core multi_agent_v2_rejects_agents_max_threadspassed locally with a temporary focused test for this behavior.cargo test -p codex-corewas also run; the new focused path passed, but the crate suite has unrelated pre-existing failures in managed config/proxy/request-permissions tests.