use a version-specific suffix for command runner binary in .sandbox-bin#19180
Merged
iceweasel-oai merged 1 commit intomainfrom Apr 23, 2026
Merged
use a version-specific suffix for command runner binary in .sandbox-bin#19180iceweasel-oai merged 1 commit intomainfrom
iceweasel-oai merged 1 commit intomainfrom
Conversation
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we copy
codex-command-runner.exeintoCODEX_HOME/.sandbox-bin/so that it can be executed by the sandbox user.We also detect if that version is stale and copy a new one in if so.
This can fail when you are running multiple versions of the app - the file in
.sandbox-bincan look stale because it comes from another app build.This change allows us to have multiple versions in there for different CLI versions, and it fallsback to a
size+mtimehash in the filename for dev builds that don't report a real CLI version.