Increase app-server WebSocket outbound buffer#19246
Merged
etraut-openai merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a41f2972a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
etraut-openai
force-pushed
the
etraut/increase-client-buffer-size
branch
2 times, most recently
from
16450ba to
8088efd
Compare
etraut-openai
force-pushed
the
etraut/increase-client-buffer-size
branch
from
8088efd to
3f2808d
Compare
maxj-oai
approved these changes
Apr 24, 2026
Contributor
maxj-oai
left a comment
maxj-oai
left a comment
There was a problem hiding this comment.
Nice let's give it a shot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18203.
Why
Remote TUI clients connected through
codex app-server --listen ws://...can receive short bursts of outbound turn and tool-output notifications. The WebSocket transport previously used the shared 128-message channel capacity for its outbound writer queue, so a healthy client that briefly lagged during normal output streaming could fill the queue and be disconnected immediately.This is a smaller mitigation than #18265: instead of adding a new overflow/backpressure pipeline, keep the existing non-blocking router behavior and give WebSocket clients enough bounded headroom for realistic bursts.
What Changed
64 * 1024messages.codex-rs/app-server/src/transport/websocket.rs.CHANNEL_CAPACITYand the existing disconnect-on-full behavior unchanged for internal/control channels and genuinely stuck clients.Verification
cargo test -p codex-app-server transport::tests::broadcast_does_not_block_on_slow_connection