Resolve relative agent role config paths from layers#19261
Merged
etraut-openai merged 1 commit intomainfrom Apr 24, 2026
Merged
Resolve relative agent role config paths from layers#19261etraut-openai merged 1 commit intomainfrom
etraut-openai merged 1 commit intomainfrom
Conversation
sayan-oai
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19257.
Summary
Agent roles declared in config layers can set
config_fileto a relative path, but deserializing the layer-local[agents.*]table happened without anAbsolutePathBufbase path. That caused configs likeconfig_file = "agents/my-role.toml"to fail withAbsolutePathBuf deserialized without a base path.This updates agent role layer loading to deserialize
[agents.*]while the layer config folder is active as the path base, matching the behavior documented forAgentRoleToml.config_file. It also adds coverage for a user config layer with a relative agent roleconfig_file.