Merged
Conversation
apanasenko-oai
force-pushed
the
anton_panasneko_add_tracing
branch
2 times, most recently
from
8d28453 to
48d2cf7
Compare
pakrym-oai
reviewed
Dec 11, 2025
pakrym-oai
reviewed
Dec 11, 2025
pakrym-oai
reviewed
Dec 11, 2025
pakrym-oai
reviewed
Dec 11, 2025
pakrym-oai
reviewed
Dec 11, 2025
pakrym-oai
reviewed
Dec 11, 2025
pakrym-oai
reviewed
Dec 11, 2025
pakrym-oai
reviewed
Dec 11, 2025
pakrym-oai
requested changes
Dec 11, 2025
Collaborator
pakrym-oai
left a comment
pakrym-oai
left a comment
There was a problem hiding this comment.
Should we add tests?
Without tests we'll quickly regress these in one of the refactorings.
apanasenko-oai
force-pushed
the
anton_panasneko_add_tracing
branch
from
48d2cf7 to
93543fc
Compare
Collaborator
Author
updated. |
apanasenko-oai
force-pushed
the
anton_panasneko_add_tracing
branch
from
93543fc to
a41f8f5
Compare
jif-oai
reviewed
Dec 12, 2025
Collaborator
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
Nice!!! Will be so helpful for debugging
| } | ||
|
|
||
| fn otel_event_manager( | ||
| fn otel_manager( |
Collaborator
There was a problem hiding this comment.
This test building function seems to be defined in different place. Should we have just one in the otel crate?
Collaborator
Author
There was a problem hiding this comment.
will refactor this in follow up review, since it's not related to tracing itself.
pakrym-oai
approved these changes
Dec 12, 2025
Collaborator
pakrym-oai
left a comment
pakrym-oai
left a comment
There was a problem hiding this comment.
Looks good, pending @jif-oai's comments.
apanasenko-oai
force-pushed
the
anton_panasneko_add_tracing
branch
2 times, most recently
from
c6eefdc to
93551c6
Compare
apanasenko-oai
force-pushed
the
anton_panasneko_add_tracing
branch
from
93551c6 to
9e8f98a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.