Changed default wrap algorithm from OptimalFit to FirstFit#7960
Merged
etraut-openai merged 2 commits intomainfrom Dec 13, 2025
Merged
Changed default wrap algorithm from OptimalFit to FirstFit#7960etraut-openai merged 2 commits intomainfrom
etraut-openai merged 2 commits intomainfrom
Conversation
Codex identified this as the cause of a reported hang: #7822. Apparently, the wrapping algorithm we're using has known issues and bad worst-case behaviors when OptimalFit is used on certain strings. It recommended switching to FirstFit instead.
joshka-oai
approved these changes
Dec 13, 2025
Collaborator
|
I've looked at textwrap a bit in the past in the context of using it within Ratatui. I took a quick look at the history of why we chose OptimalFit with those defaults and noticed that #4674 where this was introduced suggests that banning optimal fit (and turning off the smawk feature) was a reasonable idea. Avoiding a hang is a pretty good reason to choose a simpler deterministic algorithm where it's mostly equivalent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex identified this as the cause of a reported hang: #7822. Apparently, the wrapping algorithm we're using has known issues and bad worst-case behaviors when OptimalFit is used on certain strings. It recommended switching to FirstFit instead.