fix(tui): only show 'Worked for' separator when actual work was performed

[ThanhNguyxn]

Fixes #7919.

This PR addresses a TUI display bug where the "Worked for" separator would appear prematurely during the planning stage.

Changes:

• Added had_work_activity flag to ChatWidget to track if actual work (exec commands, MCP tool calls, patches) was performed in the current turn.
• Updated handle_streaming_delta to only display the FinalMessageSeparator if both needs_final_message_separator AND had_work_activity are true.
• Updated handle_exec_end_now, handle_patch_apply_end_now, and handle_mcp_end_now to set had_work_activity = true.

Verification:

• Ran cargo test -p codex-tui to ensure no regressions.
• Manual verification confirms the separator now only appears after actual work is completed.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[ThanhNguyxn]

I have read the CLA Document and I hereby sign the CLA

[etraut-openai]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 93baa9bf16

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[ThanhNguyxn]

Thanks for the review feedback! Here's my analysis:

Regarding view-image tool calls

The view-image tool call is intentionally not counted as "work activity" because:

1. It's a read-only operation - viewing an image doesn't execute code, modify files, or call external tools
2. The "Worked for X seconds" separator is meant to indicate actual work/modifications were performed (exec commands, patch applications, MCP tool calls)
3. Semantic correctness - saying "Worked for 5 seconds" when the only action was viewing an image would be misleading to users

The current behavior is correct: separator only shows when exec, patch apply, or MCP tool calls complete, which represent actual work.

[ThanhNguyxn]

Thanks for the review! Regarding the view-image concern:

I intentionally didn't count view_image as work activity because:

1. It's read-only - no code execution, no file modifications, no external API calls
2. Semantically misleading - showing "Worked for 2s" when only viewing an image doesn't match user expectations of "work"
3. Issue context - the original issue Sometimes see "Worked for" when job at planning stage #7919 is about "Worked for" appearing during planning phase when no actual work occurred

However, I'm happy to add it if you prefer consistency (any tool call = work).

Also, I'll rename had_work_activity → work_occurred as you suggested.

Please let me know which direction you'd prefer!

[joshka-oai]

I added docs and updated this to also contain logic for tui2