feat: propagate approval request of unsubscribed threads#9232
Conversation
joshka-oai
left a comment
joshka-oai
left a comment
There was a problem hiding this comment.
This needs more comments to help ground what it's doing against the intent. I don't know if any of this is right because there's nothing to refer to here that would help clarify what the intended behavior is (add doc comments and tests if possible).
joshka-oai
left a comment
joshka-oai
left a comment
There was a problem hiding this comment.
LGTM - though it seems that this behavior and the change it sits on doesn't appear to be in tui2. Perhaps add that for now?
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05d62cd62d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65f8c3be74
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
A thread can now be spawned by another thread. In order to process the approval requests of such sub-threads, we need to detect those event and show them in the TUI.
This is a temporary solution while the UX is being figured out. This PR should be reverted once done