fix windows paste behavior and add more test#9350
fix windows paste behavior and add more test#9350occurrent wants to merge 6 commits intoopenai:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 837f5672e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…w-start Windows paste bursts; add regression test.
61166c1 to
af59417
Compare
|
@etraut-openai This PR has been up for a while, could take a look? |
|
@occurrent, sorry it has taken so long to get to this. The Codex team has been incredibly busy lately preparing for the recent Codex App launch. I'm still interested in this PR if you're willing to give us a bit more time. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 446d27e749
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba1b456cb1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
I have manually tested the compiled program on the Windows platform, and so far, the scenarios I designed are behaving as expected. |
A regression slipped in after #8021, and our existing tests did not catch it. This PR fixes that regression, tightens the PasteBurst / ChatComposer heuristics around Windows key-event pastes, and adds targeted regression tests to prevent similar breakages.
changes
User-visible impact
Tests and docs