Add thread/unarchive to restore archived rollouts#9843
Conversation
|
@codex review this |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
owenlin0
left a comment
owenlin0
left a comment
There was a problem hiding this comment.
left some small comments, pre-approved
| }) | ||
| } | ||
|
|
||
| fn rollout_date_parts(file_name: &OsStr) -> Option<(String, String, String)> { |
There was a problem hiding this comment.
is there a helper function already in codex-rs/core/src/rollout/* somewhere that we can reuse? a function like this should belong there
There was a problem hiding this comment.
I don't think one already existed so I added this to codex-rs/core/src/rollout/list.rs. Does that seem reasonable?
|
@codex review this |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Summary
thread/unarchiveRPC to move archived thread rollouts back into the activesessions/tree.What changed
thread/unarchiverequest/response types and wiring.thread_unarchivein the app server.sessions/YYYY/MM/DD/...based on the rollout filename timestamp.find_archived_thread_path_by_id_strhelper for archived rollouts.sessions/.How to use
{ "method": "thread/unarchive", "id": 24, "params": { "threadId": "<thread-id>" } }Author Codex Session
codex resume 019bf158-54b6-7960-a696-9d85df7e1bc1(soon I'll make this kind of session UUID forkable by anyone with the rightsession_object_storage_urlline in their config, but for now just pasting it here for my reference)