Conversation
dylan-hurd-oai
approved these changes
Jan 27, 2026
| if should_send { | ||
| // Never await a bounded channel send on the main TUI loop: if the receiver falls behind, | ||
| // `send().await` can block and the UI stops drawing. If the channel is full, wait in a | ||
| // spawned task instead. |
Collaborator
There was a problem hiding this comment.
@codex scan all uses of channels in codex-rs and propose an AGENTS.md update with best practices to improve our usage of them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a TUI freeze caused by awaiting
mpsc::Sender::send()that blocks the tokio thread, stopping the consumption runtime and creating a deadlock. This could happen if the server was producing enough chunks to fill thempscfast enough. To solve this we try on insert using atry_send()(not requiring anawait) and delegate to a tokio task if this does not workThis is a temporary solution as it can contain races for delta elements and a stronger design should come here